Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2330753002: Update links for the SBER opt-in on interstitials (Closed)

Created:
4 years, 3 months ago by felt
Modified:
4 years, 3 months ago
Reviewers:
Nathan Parker, Mark P
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update links for the SBER opt-in on interstitials BUG=639166 TBR=mpearson@chromium.org Committed: https://crrev.com/4f76c4dddda7ee81f70cbc3b61191ce1188abd7e Cr-Commit-Position: refs/heads/master@{#418146}

Patch Set 1 : Works locally #

Total comments: 2

Patch Set 2 : Update variable name #

Messages

Total messages: 22 (14 generated)
felt
nparker, PTAL? this was a request from privacy team
4 years, 3 months ago (2016-09-12 17:47:24 UTC) #7
Nathan Parker
lgtm https://codereview.chromium.org/2330753002/diff/40001/components/security_interstitials/core/controller_client.cc File components/security_interstitials/core/controller_client.cc (right): https://codereview.chromium.org/2330753002/diff/40001/components/security_interstitials/core/controller_client.cc#newcode55 components/security_interstitials/core/controller_client.cc:55: GURL privacy_url( How about "whitepaper_url" for the var ...
4 years, 3 months ago (2016-09-13 01:06:42 UTC) #10
felt
https://codereview.chromium.org/2330753002/diff/40001/components/security_interstitials/core/controller_client.cc File components/security_interstitials/core/controller_client.cc (right): https://codereview.chromium.org/2330753002/diff/40001/components/security_interstitials/core/controller_client.cc#newcode55 components/security_interstitials/core/controller_client.cc:55: GURL privacy_url( On 2016/09/13 01:06:42, Nathan Parker wrote: > ...
4 years, 3 months ago (2016-09-13 01:45:11 UTC) #11
felt
TBR-ing mpearson for trivial histograms.xml change
4 years, 3 months ago (2016-09-13 01:46:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330753002/60001
4 years, 3 months ago (2016-09-13 01:46:36 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 3 months ago (2016-09-13 02:50:02 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4f76c4dddda7ee81f70cbc3b61191ce1188abd7e Cr-Commit-Position: refs/heads/master@{#418146}
4 years, 3 months ago (2016-09-13 02:51:39 UTC) #21
Mark P
4 years, 3 months ago (2016-09-13 04:12:13 UTC) #22
Message was sent while issue was closed.
official histograms.xml lgtm

On 2016/09/13 01:46:07, felt wrote:
> TBR-ing mpearson for trivial histograms.xml change

Powered by Google App Engine
This is Rietveld 408576698