components/security_interstitials/core/controller_client.cc - Issue 2330753002: Update links for the SBER opt-in on interstitials

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/security_interstitials/core/controller_client.cc

Issue 2330753002: Update links for the SBER opt-in on interstitials (Closed)

Patch Set: Works locally Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/security_interstitials/core/controller_client.h"	5 #include "components/security_interstitials/core/controller_client.h"

6	6

7 #include <utility>	7 #include <utility>

8	8

9 #include "components/google/core/browser/google_util.h"	9 #include "components/google/core/browser/google_util.h"

10 #include "components/prefs/pref_service.h"	10 #include "components/prefs/pref_service.h"

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43	43

44 void ControllerClient::OpenExtendedReportingPrivacyPolicy() {	44 void ControllerClient::OpenExtendedReportingPrivacyPolicy() {

45 metrics_helper_->RecordUserInteraction(MetricsHelper::SHOW_PRIVACY_POLICY);	45 metrics_helper_->RecordUserInteraction(MetricsHelper::SHOW_PRIVACY_POLICY);

46 GURL privacy_url(	46 GURL privacy_url(

47 l10n_util::GetStringUTF8(IDS_SAFE_BROWSING_PRIVACY_POLICY_URL));	47 l10n_util::GetStringUTF8(IDS_SAFE_BROWSING_PRIVACY_POLICY_URL));

48 privacy_url =	48 privacy_url =

49 google_util::AppendGoogleLocaleParam(privacy_url, GetApplicationLocale());	49 google_util::AppendGoogleLocaleParam(privacy_url, GetApplicationLocale());

50 OpenUrlInCurrentTab(privacy_url);	50 OpenUrlInCurrentTab(privacy_url);

51 }	51 }

52	52

	53 void ControllerClient::OpenExtendedReportingWhitepaper() {

	54 metrics_helper_->RecordUserInteraction(MetricsHelper::SHOW_WHITEPAPER);

	55 GURL privacy_url(
	Nathan Parker 2016/09/13 01:06:42 How about "whitepaper_url" for the var name? How about "whitepaper_url" for the var name? felt 2016/09/13 01:45:11 Done. Show quoted text On 2016/09/13 01:06:42, Nathan Parker wrote: > How about "whitepaper_url" for the var name? Done.
	56 l10n_util::GetStringUTF8(IDS_SAFE_BROWSING_WHITEPAPER_URL));

	57 privacy_url =

	58 google_util::AppendGoogleLocaleParam(privacy_url, GetApplicationLocale());

	59 OpenUrlInCurrentTab(privacy_url);

	60 }

	61

53 } // namespace security_interstitials	62 } // namespace security_interstitials

OLD	NEW