Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: components/crash_strings.grdp

Issue 2330573002: Show crash report size in crashes UI for Android. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash_strings.grdp
diff --git a/components/crash_strings.grdp b/components/crash_strings.grdp
index 7c809f551251b9f20f15c50ad2463bb100e960f3..e82a3ec5800c73cc4878621d52afcd131085ce7b 100644
--- a/components/crash_strings.grdp
+++ b/components/crash_strings.grdp
@@ -40,4 +40,7 @@
<message name="IDS_CRASH_UPLOAD_NOW_LINK_TEXT" desc="Link text for manual uploads of a crash report">
Send now
</message>
+ <message name="IDS_CRASH_SIZE_MESSAGE" desc="Format for displaying file size information for not uploaded crash reports.">
+ Crash report is <ph name="CRASH_SIZE">$1<ex>10KB</ex></ph>KB.
Mark Mentovai 2016/09/13 16:13:25 The <ex> shouldn’t have KB in it since the message
Mark Mentovai 2016/09/13 16:13:25 The way that these messages stack together gets ki
gayane -on leave until 09-2017 2016/09/13 17:40:23 Removed KB from example. I have searched for file
gayane -on leave until 09-2017 2016/09/13 17:40:23 I cannot put them in one message as the crash repo
Mark Mentovai 2016/09/13 18:21:17 gayane wrote:
Mark Mentovai 2016/09/13 18:21:17 gayane wrote:
+ </message>
</grit-part>

Powered by Google App Engine
This is Rietveld 408576698