components/crash_strings.grdp - Issue 2330573002: Show crash report size in crashes UI for Android.

Side by Side Diff: components/crash_strings.grdp

Issue 2330573002: Show crash report size in crashes UI for Android. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <grit-part>	2 <grit-part>

3	3

4 <message name="IDS_CRASH_TITLE" desc="Title for the chrome://crashes page.">	4 <message name="IDS_CRASH_TITLE" desc="Title for the chrome://crashes page.">

5 Crashes	5 Crashes

6 </message>	6 </message>

7 <message name="IDS_CRASH_CRASH_COUNT_BANNER_FORMAT" desc="Format for crash cou nt banner on chrome://crashes">	7 <message name="IDS_CRASH_CRASH_COUNT_BANNER_FORMAT" desc="Format for crash cou nt banner on chrome://crashes">

8 Crashes (<ph name="CRASH_COUNT">$1<ex>3</ex></ph>)	8 Crashes (<ph name="CRASH_COUNT">$1<ex>3</ex></ph>)

9 </message>	9 </message>

10 <message name="IDS_CRASH_CRASH_HEADER_FORMAT" desc="Format for crash entry hea dings on chrome://crashes">	10 <message name="IDS_CRASH_CRASH_HEADER_FORMAT" desc="Format for crash entry hea dings on chrome://crashes">

(...skipping 22 matching lines...) Expand all Loading...
33 </message>	33 </message>

34 <message name="IDS_CRASH_DISABLED_HEADER" desc="The header for chrome://crashe s when crash reporting is disabled">	34 <message name="IDS_CRASH_DISABLED_HEADER" desc="The header for chrome://crashe s when crash reporting is disabled">

35 Crash reporting is disabled.	35 Crash reporting is disabled.

36 </message>	36 </message>

37 <message name="IDS_CRASH_UPLOAD_MESSAGE" desc="Link text for triggering crash uploading on chrome://crashes">	37 <message name="IDS_CRASH_UPLOAD_MESSAGE" desc="Link text for triggering crash uploading on chrome://crashes">

38 Start uploading crashes	38 Start uploading crashes

39 </message>	39 </message>

40 <message name="IDS_CRASH_UPLOAD_NOW_LINK_TEXT" desc="Link text for manual uplo ads of a crash report">	40 <message name="IDS_CRASH_UPLOAD_NOW_LINK_TEXT" desc="Link text for manual uplo ads of a crash report">

41 Send now	41 Send now

42 </message>	42 </message>

	43 <message name="IDS_CRASH_SIZE_MESSAGE" desc="Format for displaying file size i nformation for not uploaded crash reports.">

	44 Crash report is <ph name="CRASH_SIZE">$1<ex>10KB</ex></ph>KB.
	Mark Mentovai 2016/09/13 16:13:25 The <ex> shouldn’t have KB in it since the message The <ex> shouldn’t have KB in it since the message has KB outside of it. But… Don’t we have tools to localize things into kB? Having it be a strict suffix like this might not always be right. Mark Mentovai 2016/09/13 16:13:25 The way that these messages stack together gets ki The way that these messages stack together gets kind of wordy and awkward: Crash report captured on Tuesday, January 25, 2011 2:58:02 PM (not yet uploaded or ignored) Crash report is 10KB. gayane -on leave until 09-2017 2016/09/13 17:40:23 Removed KB from example. I have searched for file Show quoted text On 2016/09/13 16:13:25, Mark Mentovai wrote: > The <ex> shouldn’t have KB in it since the message has KB outside of it. > > But… > > Don’t we have tools to localize things into kB? Having it be a strict suffix > like this might not always be right. Removed KB from example. I have searched for file size formatting with localization but didn't find anything useful. gayane -on leave until 09-2017 2016/09/13 17:40:23 I cannot put them in one message as the crash repo Show quoted text On 2016/09/13 16:13:25, Mark Mentovai wrote: > The way that these messages stack together gets kind of wordy and awkward: > > Crash report captured on Tuesday, January 25, 2011 2:58:02 PM (not yet uploaded > or ignored) > Crash report is 10KB. I cannot put them in one message as the crash report size doesn't always appear, but for not repeating "crash report" two times I have reworded the second message. Mark Mentovai 2016/09/13 18:21:17 gayane wrote: gayane wrote: Show quoted text > On 2016/09/13 16:13:25, Mark Mentovai wrote: > > The way that these messages stack together gets kind of wordy and awkward: > > > > Crash report captured on Tuesday, January 25, 2011 2:58:02 PM (not yet > uploaded > > or ignored) > > Crash report is 10KB. > > I cannot put them in one message as the crash report size doesn't always appear, > but for not repeating "crash report" two times I have reworded the second > message. OK. I don’t like what this page is becoming (not your fault). I filed https://crbug.com/646455 to improve it, and we can go with this for now. Mark Mentovai 2016/09/13 18:21:17 gayane wrote: gayane wrote: Show quoted text > I have searched for file size formatting with localization but didn't find > anything useful. Can we access ui/base from here? ui/base/text/bytes_formatting.h
	45 </message>

43 </grit-part>	46 </grit-part>

OLD	NEW

« components/crash/core/browser/crashes_ui_util.cc ('K') | « components/crash/core/browser/resources/crashes.js ('k') | components/upload_list/upload_list.h » ('j') | no next file with comments »