Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2330563002: [Merge-M54] arc: Make Play Store item persistent in app list. (Closed)

Created:
4 years, 3 months ago by khmel
Modified:
4 years, 3 months ago
Reviewers:
reviewer
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, sadrul, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, kalyank, Matt Giuca
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge-M54] arc: Make Play Store item persistent in app list. This uses default & OEM Arc apps support to implement Play Store as default item. Clicking it starts OptIn process or launch Play Store if Arc is already opted in. This CL also updates default apps implementation by adding install and last launch time support to correct representation of default items in the recent list. BUG=b/31242721 BUG=643686 TEST=Manually on device. TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2308643002 Cr-Commit-Position: refs/heads/master@{#416965} (cherry picked from commit ffb325645bf768c7c83a7008f40c07ec5b29de8a)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -165 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_icon.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_icon.cc View 6 chunks +44 lines, -44 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_launcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_launcher.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 14 chunks +125 lines, -102 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 4 chunks +83 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 3 chunks +18 lines, -8 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_default_app_list.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_default_app_list.cc View 3 chunks +26 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330563002/1
4 years, 3 months ago (2016-09-09 20:30:14 UTC) #2
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 20:51:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698