arc: Make Play Store item persistent in app list.

arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play
Store as default item. Clicking it starts OptIn process or
launch Play Store if Arc is already opted in. This CL also
updates default apps implementation by adding install and
last launch time support to correct representation of
default items in the recent list.

BUG=b/31242721
BUG=643686
TEST=Manually on device.

Committed: https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a
Cr-Commit-Position: refs/heads/master@{#416965}

[khmel, 2016-09-02 17:19:01]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2016-09-02 17:19:02]

Hi Xiyuan,

PTAL

once you are back.

Thanks

[khmel, 2016-09-02 17:19:52]

Description was changed from

==========
arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play Store as
default item. Clicking it starts Opt In process or launch Play Store
if Arc is alredy opted in. This CL also update defult apps mplmentation
by adding install and last  launch time support to correct represent
items in recent list.

BUG=b/31242721
BUG=643686
TEST=Manually on device.
==========

to

==========
arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play Store as
default item. Clicking it starts Opt In process or launch Play Store
if Arc is already opted in. This CL also update default apps implmentation
by adding install and last  launch time support to correct representation 
of default items in recent list.

BUG=b/31242721
BUG=643686
TEST=Manually on device.
==========

[khmel, 2016-09-02 17:23:22]

Description was changed from

==========
arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play Store as
default item. Clicking it starts Opt In process or launch Play Store
if Arc is already opted in. This CL also update default apps implmentation
by adding install and last  launch time support to correct representation 
of default items in recent list.

BUG=b/31242721
BUG=643686
TEST=Manually on device.
==========

to

==========
arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play
Store as default item. Clicking it starts OptIn process or
launch Play Store if Arc is already opted in. This CL also
updates default apps implementation by adding install and
last launch time support to correct representation of
default items in the recent list.

BUG=b/31242721
BUG=643686
TEST=Manually on device.
==========

[xiyuan, 2016-09-06 21:24:46]

https://codereview.chromium.org/2308643002/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right):

https://codereview.chromium.org/2308643002/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:246: // PlayStore is
automatically opened on sing in completed.
nit: sing -> sign

https://codereview.chromium.org/2308643002/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:247: if (app_id !=
kPlayStoreAppId) {
What happens if arc is enabled (i.e. no opt-in needed) but we are waiting for it
to finish boot?

[khmel, 2016-09-06 23:11:59]

Thanks Xiyuan for your comments.

PTAL

https://codereview.chromium.org/2308643002/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right):

https://codereview.chromium.org/2308643002/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:246: // PlayStore is
automatically opened on sing in completed.
On 2016/09/06 21:24:46, xiyuan wrote:
> nit: sing -> sign

Done.

https://codereview.chromium.org/2308643002/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:247: if (app_id !=
kPlayStoreAppId) {
On 2016/09/06 21:24:46, xiyuan wrote:
> What happens if arc is enabled (i.e. no opt-in needed) but we are waiting for
it
> to finish boot? 

Good point, I reduced check condition. (Making Play Store deferred as any other
app regardless of Arc Enabled state looks not good. In case  Arc was disabled
and we enable it here and add a deferred launch then spinning animation is shown
for a few seconds until OptIn window gets activated. That it is why I am adding
special handling of PlayStore launch)

[xiyuan, 2016-09-06 23:19:14]

lgtm

[khmel, 2016-09-06 23:22:38]

khmel@chromium.org changed reviewers:
+ skuhne@chromium.org

[khmel, 2016-09-06 23:22:39]

Thanks Xiyuan!

Adding Stefan

c/b/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

PTAL

[Mr4D (OOO till 08-26), 2016-09-07 02:24:05]

c/b/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

lgtm. I leave it to you to address the comment (or not).

https://codereview.chromium.org/2308643002/diff/40001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
(right):

https://codereview.chromium.org/2308643002/diff/40001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:883:
true /* launchable */, app_info.orientation_lock);
BTW: It would be much better readible when each parameter goes into a separate
line (as is requested by style guide).

[khmel, 2016-09-07 14:59:19]

https://codereview.chromium.org/2308643002/diff/40001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
(right):

https://codereview.chromium.org/2308643002/diff/40001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:883:
true /* launchable */, app_info.orientation_lock);
On 2016/09/07 02:24:05, Mr4D wrote:
> BTW: It would be much better readible when each parameter goes into a separate
> line (as is requested by style guide).

I understand your point, but requested before commit git cl format
chrome/browser/ui/ash suggests this variant.

[khmel, 2016-09-07 14:59:32]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2016-09-07 14:59:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 15:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 15:38:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[khmel, 2016-09-07 15:56:34]

The CQ bit was checked by khmel@chromium.org

[khmel, 2016-09-07 15:56:34]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
skuhne@chromium.org
Link to the patchset: https://codereview.chromium.org/2308643002/#ps60001
(title: "fix unit_tests")

[commit-bot: I haz the power, 2016-09-07 15:57:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 16:43:04]

Description was changed from

==========
arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play
Store as default item. Clicking it starts OptIn process or
launch Play Store if Arc is already opted in. This CL also
updates default apps implementation by adding install and
last launch time support to correct representation of
default items in the recent list.

BUG=b/31242721
BUG=643686
TEST=Manually on device.
==========

to

==========
arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play
Store as default item. Clicking it starts OptIn process or
launch Play Store if Arc is already opted in. This CL also
updates default apps implementation by adding install and
last launch time support to correct representation of
default items in the recent list.

BUG=b/31242721
BUG=643686
TEST=Manually on device.
==========

[commit-bot: I haz the power, 2016-09-07 16:43:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-07 16:46:16]

Description was changed from

==========
arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play
Store as default item. Clicking it starts OptIn process or
launch Play Store if Arc is already opted in. This CL also
updates default apps implementation by adding install and
last launch time support to correct representation of
default items in the recent list.

BUG=b/31242721
BUG=643686
TEST=Manually on device.
==========

to

==========
arc: Make Play Store item persistent in app list.

This uses default & OEM Arc apps support to implement Play
Store as default item. Clicking it starts OptIn process or
launch Play Store if Arc is already opted in. This CL also
updates default apps implementation by adding install and
last launch time support to correct representation of
default items in the recent list.

BUG=b/31242721
BUG=643686
TEST=Manually on device.

Committed: https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a
Cr-Commit-Position: refs/heads/master@{#416965}
==========

[commit-bot: I haz the power, 2016-09-07 16:46:17]

Patchset 4 (id:??) landed as
https://crrev.com/ffb325645bf768c7c83a7008f40c07ec5b29de8a
Cr-Commit-Position: refs/heads/master@{#416965}