Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: media/midi/midi_manager_alsa.cc

Issue 2330543002: Change unique_ptr::reset() for std::move (Closed)
Patch Set: Change linked_ptr to unique_ptr Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/gpu/v4l2_video_decode_accelerator.cc ('K') | « media/gpu/vp9_decoder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager_alsa.cc
diff --git a/media/midi/midi_manager_alsa.cc b/media/midi/midi_manager_alsa.cc
index a5caf8c3d1f8a15a252352a82ff030b9a22d5425..b83a17102f9b3b5de3b039f0696631fa2d964e21 100644
--- a/media/midi/midi_manager_alsa.cc
+++ b/media/midi/midi_manager_alsa.cc
@@ -269,11 +269,11 @@ void MidiManagerAlsa::StartInitialization() {
// initialize these earlier, since they need to be destroyed by the
// thread that calls Finalize(), not the destructor thread (and we
// check this in the destructor).
- in_client_.reset(in_client.release());
- out_client_.reset(out_client.release());
- decoder_.reset(decoder.release());
- udev_.reset(udev.release());
- udev_monitor_.reset(udev_monitor.release());
+ in_client_ = std::move(in_client);
+ out_client_ = std::move(out_client);
+ decoder_ = std::move(decoder);
+ udev_ = std::move(udev);
+ udev_monitor_ = std::move(udev_monitor);
// Generate hotplug events for existing ports.
// TODO(agoode): Check the return value for failure.
« media/gpu/v4l2_video_decode_accelerator.cc ('K') | « media/gpu/vp9_decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698