Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: media/gpu/v4l2_video_decode_accelerator.cc

Issue 2330543002: Change unique_ptr::reset() for std::move (Closed)
Patch Set: Change linked_ptr to unique_ptr Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/webm/cluster_builder.cc ('k') | media/gpu/vaapi_video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/v4l2_video_decode_accelerator.cc
diff --git a/media/gpu/v4l2_video_decode_accelerator.cc b/media/gpu/v4l2_video_decode_accelerator.cc
index 41aacbff4a67e203e8124f8dda51394920f98b40..c8154d9ea2f4ae64d6314a8242315d460ebb0b04 100644
--- a/media/gpu/v4l2_video_decode_accelerator.cc
+++ b/media/gpu/v4l2_video_decode_accelerator.cc
@@ -648,14 +648,15 @@ void V4L2VideoDecodeAccelerator::DecodeBufferTask() {
// We're waiting for a new buffer -- exit without scheduling a new task.
return;
}
- linked_ptr<BitstreamBufferRef>& buffer_ref = decoder_input_queue_.front();
+ std::unique_ptr<BitstreamBufferRef>& buffer_ref =
sandersd (OOO until July 31) 2016/09/13 18:30:59 This change does not make sense to me, since the q
+ decoder_input_queue_.front();
if (decoder_delay_bitstream_buffer_id_ == buffer_ref->input_id) {
// We're asked to delay decoding on this and subsequent buffers.
return;
}
// Setup to use the next buffer.
- decoder_current_bitstream_buffer_.reset(buffer_ref.release());
+ decoder_current_bitstream_buffer_ = std::move(buffer_ref);
decoder_input_queue_.pop();
const auto& shm = decoder_current_bitstream_buffer_->shm;
if (shm) {
« no previous file with comments | « media/formats/webm/cluster_builder.cc ('k') | media/gpu/vaapi_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698