media/gpu/vaapi_video_decode_accelerator.cc - Issue 2330543002: Change unique_ptr::reset() for std::move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/vaapi_video_decode_accelerator.cc

Issue 2330543002: Change unique_ptr::reset() for std::move (Closed)

Patch Set: Change linked_ptr to unique_ptr Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/gpu/vaapi_video_decode_accelerator.cc

diff --git a/media/gpu/vaapi_video_decode_accelerator.cc b/media/gpu/vaapi_video_decode_accelerator.cc

index 1d986fc826794efc63a40e6520c864d1a9d0cc0f..c6d82f16b6268169f47dd720f0d8afea945cd0a1 100644

--- a/media/gpu/vaapi_video_decode_accelerator.cc

+++ b/media/gpu/vaapi_video_decode_accelerator.cc

@@ -486,7 +486,7 @@ void VaapiVideoDecodeAccelerator::MapAndQueueNewInputBuffer(

// Set up a new input buffer and queue it for later.

linked_ptr<InputBuffer> input_buffer(new InputBuffer());

- input_buffer->shm.reset(shm.release());

+ input_buffer->shm = std::move(shm);

input_buffer->id = bitstream_buffer.id();

++num_stream_bufs_at_decoder_;