Change unique_ptr::reset() for std::move

Change unique_ptr::reset() for std::move

BUG=644626
Committed: https://crrev.com/8e7155967dd6101ffb529c76005c7cccc75c26c8
Cr-Commit-Position: refs/heads/master@{#418616}

[Brusi, 2016-09-09 19:54:17]

The CQ bit was checked by brusi_roy@hotmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 19:55:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 19:55:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 19:55:07]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Brusi, 2016-09-09 20:05:40]

Description was changed from

==========
Change unique_ptr::reset() for std::move

BUG=644626
==========

to

==========
Change unique_ptr::reset() for std::move

BUG=644626
==========

[Brusi, 2016-09-09 20:05:41]

brusi_roy@hotmail.com changed reviewers:
+ sandersd@chromium.org, thestig@chromium.org

[sandersd (OOO until July 31), 2016-09-12 18:58:42]

lgtm

[Brusi, 2016-09-12 21:05:59]

The CQ bit was checked by brusi_roy@hotmail.com

[commit-bot: I haz the power, 2016-09-12 21:06:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 21:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:21:46]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Brusi, 2016-09-13 18:02:15]

The CQ bit was checked by brusi_roy@hotmail.com

[Brusi, 2016-09-13 18:02:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2330543002/#ps20001
(title: "Change linked_ptr to unique_ptr")

[commit-bot: I haz the power, 2016-09-13 18:03:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 18:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:15:29]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[sandersd (OOO until July 31), 2016-09-13 18:30:59]

https://codereview.chromium.org/2330543002/diff/20001/media/gpu/v4l2_video_de...
File media/gpu/v4l2_video_decode_accelerator.cc (right):

https://codereview.chromium.org/2330543002/diff/20001/media/gpu/v4l2_video_de...
media/gpu/v4l2_video_decode_accelerator.cc:651:
std::unique_ptr<BitstreamBufferRef>& buffer_ref =
This change does not make sense to me, since the queue is of linked_ptrs.

[Brusi, 2016-09-14 00:59:17]

The CQ bit was checked by brusi_roy@hotmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 00:59:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brusi, 2016-09-14 01:06:47]

On 2016/09/13 18:30:59, sandersd wrote:

> This change does not make sense to me, since the queue is of linked_ptrs.

You are right! I don't know how I missed that. Also, thank you for bearing with
me, this is my first patch so I'm having a bit of trouble.
Lastly, a newbie question if you have time: Is it normal that when I modify a
file in src/media/... and then run `ninja -C out/Default chrome` I get "no work
to do."? Is it because this file is not use on my platform?

Thank you.

[commit-bot: I haz the power, 2016-09-14 05:11:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 05:11:38]

Dry run: This issue passed the CQ dry run.

[sandersd (OOO until July 31), 2016-09-14 17:45:16]

On 2016/09/14 01:06:47, Brusi wrote:
> On 2016/09/13 18:30:59, sandersd wrote:
> 
> > This change does not make sense to me, since the queue is of linked_ptrs.
> 
> You are right! I don't know how I missed that. Also, thank you for bearing
with
> me, this is my first patch so I'm having a bit of trouble.
> Lastly, a newbie question if you have time: Is it normal that when I modify a
> file in src/media/... and then run `ninja -C out/Default chrome` I get "no
work
> to do."? Is it because this file is not use on my platform?
> 
> Thank you.

This is the expected result, if indeed the file is not in use on your platform.

You can check with the gn refs command:
  gn refs <out dir> //<file path> --all

For example, with a Linux target:
  $ gn refs out/Debug //media/base/video_frame.cc --all | grep chrome$
  //chrome:chrome
  $

  $ gn refs out/Debug //media/base/gpu/vaapi_video_decode_accelerator.cc --all |
grep chrome$
  $

[Brusi, 2016-09-14 17:50:05]

On 2016/09/14 17:45:16, sandersd wrote:
> On 2016/09/14 01:06:47, Brusi wrote:
> > On 2016/09/13 18:30:59, sandersd wrote:
> > 
> > > This change does not make sense to me, since the queue is of linked_ptrs.
> > 
> > You are right! I don't know how I missed that. Also, thank you for bearing
> with
> > me, this is my first patch so I'm having a bit of trouble.
> > Lastly, a newbie question if you have time: Is it normal that when I modify
a
> > file in src/media/... and then run `ninja -C out/Default chrome` I get "no
> work
> > to do."? Is it because this file is not use on my platform?
> > 
> > Thank you.
> 
> This is the expected result, if indeed the file is not in use on your
platform.
> 
> You can check with the gn refs command:
>   gn refs <out dir> //<file path> --all
> 
> For example, with a Linux target:
>   $ gn refs out/Debug //media/base/video_frame.cc --all | grep chrome$
>   //chrome:chrome
>   $
> 
>   $ gn refs out/Debug //media/base/gpu/vaapi_video_decode_accelerator.cc --all
|
> grep chrome$
>   $

OK! thanks I will look into it! Is this patch ready to be committed?

[sandersd (OOO until July 31), 2016-09-14 17:58:10]

On 2016/09/14 17:50:05, Brusi wrote:
> On 2016/09/14 17:45:16, sandersd wrote:
> > On 2016/09/14 01:06:47, Brusi wrote:
> > > On 2016/09/13 18:30:59, sandersd wrote:
> > > 
> > > > This change does not make sense to me, since the queue is of
linked_ptrs.
> > > 
> > > You are right! I don't know how I missed that. Also, thank you for bearing
> > with
> > > me, this is my first patch so I'm having a bit of trouble.
> > > Lastly, a newbie question if you have time: Is it normal that when I
modify
> a
> > > file in src/media/... and then run `ninja -C out/Default chrome` I get "no
> > work
> > > to do."? Is it because this file is not use on my platform?
> > > 
> > > Thank you.
> > 
> > This is the expected result, if indeed the file is not in use on your
> platform.
> > 
> > You can check with the gn refs command:
> >   gn refs <out dir> //<file path> --all
> > 
> > For example, with a Linux target:
> >   $ gn refs out/Debug //media/base/video_frame.cc --all | grep chrome$
> >   //chrome:chrome
> >   $
> > 
> >   $ gn refs out/Debug //media/base/gpu/vaapi_video_decode_accelerator.cc
--all
> |
> > grep chrome$
> >   $
> 
> OK! thanks I will look into it! Is this patch ready to be committed?

I believe so. With straightforward changes like these we have pretty good faith
in the tests :-).

[Brusi, 2016-09-14 18:17:03]

The CQ bit was checked by brusi_roy@hotmail.com

[Brusi, 2016-09-14 18:17:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2330543002/#ps40001
(title: "Change unique_ptr::reset() for std::move")

[commit-bot: I haz the power, 2016-09-14 18:17:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 18:23:21]

Description was changed from

==========
Change unique_ptr::reset() for std::move

BUG=644626
==========

to

==========
Change unique_ptr::reset() for std::move

BUG=644626
==========

[commit-bot: I haz the power, 2016-09-14 18:23:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 18:25:06]

Description was changed from

==========
Change unique_ptr::reset() for std::move

BUG=644626
==========

to

==========
Change unique_ptr::reset() for std::move

BUG=644626

Committed: https://crrev.com/8e7155967dd6101ffb529c76005c7cccc75c26c8
Cr-Commit-Position: refs/heads/master@{#418616}
==========

[commit-bot: I haz the power, 2016-09-14 18:25:07]

Patchset 3 (id:??) landed as
https://crrev.com/8e7155967dd6101ffb529c76005c7cccc75c26c8
Cr-Commit-Position: refs/heads/master@{#418616}