media/base/byte_queue.cc - Issue 2330543002: Change unique_ptr::reset() for std::move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/byte_queue.cc

Issue 2330543002: Change unique_ptr::reset() for std::move (Closed)

Patch Set: Change unique_ptr::reset() for std::move Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/byte_queue.cc

diff --git a/media/base/byte_queue.cc b/media/base/byte_queue.cc

index 6ff60e648671135989c7ad207cbee21512b3dd69..94000fac33788546f2d4bbeeebe4f9960f08c2f3 100644

--- a/media/base/byte_queue.cc

+++ b/media/base/byte_queue.cc

@@ -45,7 +45,7 @@ void ByteQueue::Push(const uint8_t* data, int size) {

if (used_ > 0)

memcpy(new_buffer.get(), front(), used_);

- buffer_.reset(new_buffer.release());

+ buffer_ = std::move(new_buffer);

size_ = new_size;

offset_ = 0;

} else if ((offset_ + used_ + size) > size_) {

« no previous file with comments | « AUTHORS ('k') | media/base/video_frame.cc » ('j') | no next file with comments »