Issue 2330503002: work in progress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2330503002: work in progress (Closed)

Created:
4 years, 3 months ago by hal.canary

Modified:
4 years, 3 months ago

Reviewers:

CC:
reviews_skia.org

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

work in progress COMMIT=false BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330503002

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+261 lines, -134 lines)			Patch
M	src/pdf/SkPDFDevice.h	View	2 chunks	+11 lines, -11 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	12 chunks	+238 lines, -117 lines	0 comments	Download
M	src/pdf/SkPDFFont.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFResourceDict.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFResourceDict.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/pdf/SkScopeExit.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Depends on Patchset:

Total messages: 3 (3 generated)

hal.canary

Description was changed from ========== work in progress COMMIT=false BUG=skia: ========== to ========== work in ...

4 years, 3 months ago (2016-09-09 18:17:15 UTC) #1

hal.canary

The CQ bit was checked by halcanary@google.com to run a CQ dry run

4 years, 3 months ago (2016-09-09 18:17:22 UTC) #2

commit-bot: I haz the power

4 years, 3 months ago (2016-09-09 18:17:31 UTC) #3

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...