Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2300393002: SkPDF: implement drawTextBlob() (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: implement drawTextBlob() Pass new fields from https://skia.googlesource.com/skia/+/4f0a23a into SkPDFDevice::internalDrawText() (a later CL will use them for /ActualText. No change in PDF output. BUG=skia:5434 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300393002 Committed: https://skia.googlesource.com/skia/+/e06ca96174b99d451db17540a8df540035ab020d

Patch Set 1 : 2016-09-02 (Friday) 10:00:45 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M src/pdf/SkPDFDevice.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 5 chunks +37 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300393002/1
4 years, 3 months ago (2016-09-02 13:57:53 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-02 13:57:54 UTC) #5
hal.canary
incremental change
4 years, 3 months ago (2016-09-02 16:51:09 UTC) #14
hal.canary
Adding you as a reviewer, since bungeman@ seems to be taking the week off. This ...
4 years, 3 months ago (2016-09-09 11:26:23 UTC) #16
tomhudson
lgtm
4 years, 3 months ago (2016-09-09 12:06:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300393002/20001
4 years, 3 months ago (2016-09-09 12:06:57 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 12:34:58 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/e06ca96174b99d451db17540a8df540035ab020d

Powered by Google App Engine
This is Rietveld 408576698