Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: third_party/WebKit/Source/platform/animation/TimingFunction.cpp

Issue 2330283004: Fix serialization of step timing functions (Closed)
Patch Set: Update step timing function parsing in devtools Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/animation/TimingFunction.cpp
diff --git a/third_party/WebKit/Source/platform/animation/TimingFunction.cpp b/third_party/WebKit/Source/platform/animation/TimingFunction.cpp
index aea7cda2341a94dd8225703dc46bad35cf5bbe09..7bef81e4c65a420ed3b1c48a1d0427d23796f409 100644
--- a/third_party/WebKit/Source/platform/animation/TimingFunction.cpp
+++ b/third_party/WebKit/Source/platform/animation/TimingFunction.cpp
@@ -86,21 +86,18 @@ String StepsTimingFunction::toString() const
positionString = "middle";
break;
case StepPosition::END:
- positionString = "end";
+ // do not specify step position in output
break;
}
StringBuilder builder;
- if (this->numberOfSteps() == 1) {
- builder.append("step-");
- builder.append(positionString);
- } else {
- builder.append("steps(");
- builder.append(String::numberToStringECMAScript(this->numberOfSteps()));
+ builder.append("steps(");
+ builder.append(String::numberToStringECMAScript(this->numberOfSteps()));
+ if (positionString) {
builder.append(", ");
builder.append(positionString);
- builder.append(')');
}
+ builder.append(')');
return builder.toString();
}

Powered by Google App Engine
This is Rietveld 408576698