Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Issue 2330103002: gpu, cmaa: copy RGBA8 texture via glCopyTexSubImage2D() instead of imageStore(). (Closed)

Created:
4 years, 3 months ago by robert.bradford
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

gpu, cmaa: copy RGBA8 texture via glCopyTexSubImage2D() instead of imageStore(). CMAA uses imageStore() to copy RGBA8 to RGBA8 texture. At the moment, we expect the FBO is not updated. However, some drivers (e.g. Intel Mesa) fill random color on the FBO in the case. It causes ugly artifact in the later CMAA phase. This CL copies RGBA8 texture via glCopyTexSubImage2D(), instead of custom shader and glDrawArrays. It fixes the bug as well as speeds up copy. BUG=642290 TEST=chromeos camera app on Samus https://chrome.google.com/webstore/detail/camera/hfhhnacclhffhdffklopdkcgdhifgngh CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2298613010 Cr-Commit-Position: refs/heads/master@{#416538} (cherry picked from commit b2d7e66345c253f353d1d3c555964f6e95e26b9c) Committed: https://chromium.googlesource.com/chromium/src/+/41f75bc0f1ac9e8956007c1c7d95180e7efaf225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -82 lines) Patch
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h View 3 chunks +1 line, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 10 chunks +18 lines, -77 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
robert.bradford
4 years, 3 months ago (2016-09-12 16:19:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41f75bc0f1ac9e8956007c1c7d95180e7efaf225.

Powered by Google App Engine
This is Rietveld 408576698