Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2330073002: Revert "[v8][wasm] Handles finally in try/finally blocks." (Closed)

Created:
4 years, 3 months ago by John
Modified:
4 years, 3 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[v8][wasm] Handles finally in try/finally blocks." This reverts commit cf5180c3ef1805e29dd29c02f8604212d6de911b. It turns out finally blocks aren't useful in the current incarnation of Wasm. We might reintroduce it later. BUG= Committed: https://crrev.com/fb4a190cee424fa0c774b84230c0b669b68594d3 Cr-Commit-Position: refs/heads/master@{#39390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -569 lines) Patch
M src/wasm/ast-decoder.cc View 20 chunks +49 lines, -251 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/wasm/test-run-wasm-try-catch.cc View 1 chunk +0 lines, -317 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
John
4 years, 3 months ago (2016-09-12 15:57:29 UTC) #4
bradnelson
lgtm
4 years, 3 months ago (2016-09-12 16:00:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330073002/1
4 years, 3 months ago (2016-09-13 17:06:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330073002/1
4 years, 3 months ago (2016-09-13 17:09:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 17:30:00 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 17:30:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb4a190cee424fa0c774b84230c0b669b68594d3
Cr-Commit-Position: refs/heads/master@{#39390}

Powered by Google App Engine
This is Rietveld 408576698