Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 233003002: Revert of Blink roll 171141:171225 (Closed)

Created:
6 years, 8 months ago by dzhioev (left Google)
Modified:
6 years, 8 months ago
Reviewers:
yurys, eseidel
CC:
chromium-reviews, jianli, yurys
Visibility:
Public.

Description

Revert of Blink roll 171141:171225 (https://codereview.chromium.org/232453002/) Reason for revert: Chrome for ChromeOS build is failing: chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp: In member function 'void WebCore::CharacterData::replaceData(unsigned int, unsigned int, const WTF::String&, WebCore::ExceptionState&)': chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp:146:36: error: 'realCount' may be used uninitialized in this function [-Werror=maybe-uninitialized] chromeos-chrome-36.0.1934.0_alpha-r1: newStr.remove(offset, realCount); chromeos-chrome-36.0.1934.0_alpha-r1: ^ chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp: In member function 'void WebCore::CharacterData::deleteData(unsigned int, unsigned int, WebCore::ExceptionState&, WebCore::CharacterData::RecalcStyleBehavior)': chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp:132:36: error: 'realCount' may be used uninitialized in this function [-Werror=maybe-uninitialized] chromeos-chrome-36.0.1934.0_alpha-r1: newStr.remove(offset, realCount); chromeos-chrome-36.0.1934.0_alpha-r1: ^ Original issue's description: > Blink roll 171141:171225 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171141:171225&mode=html > TBR= > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262942 TBR=eseidel@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dzhioev (left Google)
Created Revert of Blink roll 171141:171225
6 years, 8 months ago (2014-04-10 11:31:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/233003002/1
6 years, 8 months ago (2014-04-10 11:32:10 UTC) #2
commit-bot: I haz the power
Change committed as 262950
6 years, 8 months ago (2014-04-10 11:32:41 UTC) #3
yurys
6 years, 8 months ago (2014-04-10 11:54:54 UTC) #4
Message was sent while issue was closed.
FYI: the problem was fixed in https://codereview.chromium.org/232243004

Powered by Google App Engine
This is Rietveld 408576698