Issue 232243004: Fix compilation on Chromium OS after r171165

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232243004: Fix compilation on Chromium OS after r171165 (Closed)

Created:
6 years, 8 months ago by yurys

Modified:
6 years, 8 months ago

Reviewers:
sof, jianli, eseidel

CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Fix compilation on Chromium OS after r171165 r171165 broke compilation on Chromium OS bot and we had to revert Blink roll. ... ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp:146:36: error: 'realCount' may be used uninitialized in this function ... I simply added initialization for realCount variables to make the compiler happy. [1] http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/20955 BUG=349898 TBR=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171240

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/dom/CharacterData.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

yurys

Committed patchset #1 manually as r171240 (presubmit successful).

6 years, 8 months ago (2014-04-10 07:41:17 UTC) #2

sof

6 years, 8 months ago (2014-04-10 07:42:44 UTC) #3

Message was sent while issue was closed.

lgtm, thanks! (https://codereview.chromium.org/232603002/ does the same.)