Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Unified Diff: media/gpu/v4l2_video_decode_accelerator.cc

Issue 2329913002: V4L2VideoDecodeAccelerator: fix frame returned after processor destroys. (Closed)
Patch Set: V4L2VideoDecodeAccelerator: fix frame returned after processor destroys. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/v4l2_video_decode_accelerator.cc
diff --git a/media/gpu/v4l2_video_decode_accelerator.cc b/media/gpu/v4l2_video_decode_accelerator.cc
index 41aacbff4a67e203e8124f8dda51394920f98b40..e4fb67e4d3a61736610d61ea343502c0bf96f1d7 100644
--- a/media/gpu/v4l2_video_decode_accelerator.cc
+++ b/media/gpu/v4l2_video_decode_accelerator.cc
@@ -22,7 +22,6 @@
#include "base/threading/thread_task_runner_handle.h"
#include "base/trace_event/trace_event.h"
#include "build/build_config.h"
-#include "media/base/bind_to_current_loop.h"
#include "media/base/media_switches.h"
#include "media/filters/h264_parser.h"
#include "media/gpu/shared_memory_region.h"
@@ -1227,14 +1226,11 @@ void V4L2VideoDecodeAccelerator::Dequeue() {
coded_size_, gfx::Rect(visible_size_), visible_size_, fds,
base::TimeDelta());
// Unretained is safe because |this| owns image processor and there will
- // be no callbacks after processor destroys. Also, this class ensures it
- // is safe to post a task from child thread to decoder thread using
- // Unretained.
+ // be no callbacks after processor destroys.
image_processor_->Process(
frame, dqbuf.index,
- BindToCurrentLoop(
- base::Bind(&V4L2VideoDecodeAccelerator::FrameProcessed,
- base::Unretained(this), bitstream_buffer_id)));
+ base::Bind(&V4L2VideoDecodeAccelerator::FrameProcessed,
+ base::Unretained(this), bitstream_buffer_id));
} else {
output_record.state = kAtClient;
decoder_frames_at_client_++;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698