Chromium Code Reviews| Index: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h |
| diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h |
| index e3fe5ed731885efa863a60f29ad2101999f20922..04e0c93c17079166bf5a6b4d7d84d3a58e3f48c6 100644 |
| --- a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h |
| +++ b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h |
| @@ -65,8 +65,6 @@ public: |
| return m_imageFilters[0] || m_imageFilters[1] || m_imageFilters[2] || m_imageFilters[3]; |
| } |
| - IntRect absolutePaintRect() const { return m_absolutePaintRect; } |
| - |
| // Clipped primitive subregion in the coordinate space of the target. |
| FloatRect absoluteBounds() const; |
| @@ -106,8 +104,8 @@ public: |
| ColorSpace operatingColorSpace() const { return m_operatingColorSpace; } |
| virtual void setOperatingColorSpace(ColorSpace colorSpace) { m_operatingColorSpace = colorSpace; } |
| - virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect); |
| - virtual bool affectsTransparentPixels() { return false; } |
| + virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect) const; |
|
pdr.
2016/09/12 02:46:34
Can you document this with a comment?
fs
2016/09/12 08:55:19
Done.
|
| + virtual bool affectsTransparentPixels() const { return false; } |
| // Return false if the filter will only operate correctly on valid RGBA values, with |
| // alpha in [0,255] and each color component in [0, alpha]. |
| @@ -130,13 +128,9 @@ protected: |
| SkImageFilter::CropRect getCropRect() const; |
| - void addAbsolutePaintRect(const FloatRect& absolutePaintRect); |
| - |
| private: |
| FilterEffectVector m_inputEffects; |
| - IntRect m_absolutePaintRect; |
| - |
| Member<Filter> m_filter; |
| // The following member variables are SVG specific and will move to LayoutSVGResourceFilterPrimitive. |