Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2329543002: services/ui: Use new gpu::GpuInit to do the GPU initialization. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 3 months ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Use new gpu::GpuInit to do the GPU initialization. Initially committed in r418062, but reverted in r418105. The fix is a missing null-check. BUG=643746 Committed: https://crrev.com/6ffb1ab0a356125ce696c3914da64fa154a6c90e Cr-Commit-Position: refs/heads/master@{#418165}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tot merge #

Patch Set 4 : nullcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -45 lines) Patch
M services/ui/gpu/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A services/ui/gpu/gpu_main.h View 1 chunk +42 lines, -0 lines 0 comments Download
A services/ui/gpu/gpu_main.cc View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.h View 6 chunks +11 lines, -14 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.cc View 6 chunks +9 lines, -26 lines 0 comments Download
M services/ui/ws/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 29 (19 generated)
sadrul
fsamuel@ for services/ui/gpu sky@ for services/ui/ws
4 years, 3 months ago (2016-09-09 19:44:11 UTC) #6
Fady Samuel
Hooray for code sharing! Thanks Sadrul! LGTM!
4 years, 3 months ago (2016-09-09 20:04:16 UTC) #7
sky
ui/ws LGTM
4 years, 3 months ago (2016-09-09 22:01:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329543002/40001
4 years, 3 months ago (2016-09-12 20:07:42 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-12 21:48:27 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/8b2d8a7287c3a02a2398aded54429d5b2f1b411a Cr-Commit-Position: refs/heads/master@{#418062}
4 years, 3 months ago (2016-09-12 21:51:09 UTC) #18
lazyboy
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2338483003/ by lazyboy@chromium.org. ...
4 years, 3 months ago (2016-09-12 23:39:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329543002/60001
4 years, 3 months ago (2016-09-13 03:38:40 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-13 04:04:02 UTC) #27
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 04:06:04 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6ffb1ab0a356125ce696c3914da64fa154a6c90e
Cr-Commit-Position: refs/heads/master@{#418165}

Powered by Google App Engine
This is Rietveld 408576698