third_party/WebKit/Source/bindings/core/v8/V8StringResource.h - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8StringResource.h

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8StringResource.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8StringResource.h b/third_party/WebKit/Source/bindings/core/v8/V8StringResource.h

index c9677e65edbe8cc25bf8a32701a973544bcbd83a..ad65db2dfd63edf27e0d614047d1954c556434cb 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8StringResource.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8StringResource.h

@@ -155,7 +155,7 @@ class WebCoreStringResource8 final

enum ExternalMode { Externalize, DoNotExternalize };

template <typename StringType>

-CORE_EXPORT StringType v8StringToWebCoreString(v8::Local<v8::String>,

+CORE_EXPORT StringType V8StringToWebCoreString(v8::Local<v8::String>,

ExternalMode);

CORE_EXPORT String int32ToWebCoreString(int value);