third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8StringResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp b/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

index d9d8c3938923b55a0a903150b8a82afa47464dfb..60262bb8c51fcde97b6641cd7dd0bcb2e335da46 100644

--- a/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

@@ -27,7 +27,7 @@ TEST(NativeValueTraitsImplTest, IDLInterface) {

V8TestingScope scope;

{

DummyExceptionStateForTesting exceptionState;

- Internals* internals = NativeValueTraits<Internals>::nativeValue(

+ Internals* internals = NativeValueTraits<Internals>::NativeValue(

scope.isolate(), v8::Number::New(scope.isolate(), 42), exceptionState);

EXPECT_TRUE(exceptionState.hadException());

EXPECT_EQ("Unable to convert value to Internals.",

@@ -37,7 +37,7 @@ TEST(NativeValueTraitsImplTest, IDLInterface) {

{

DummyExceptionStateForTesting exceptionState;

TestSequenceCallback* callbackFunction =

- NativeValueTraits<TestSequenceCallback>::nativeValue(

+ NativeValueTraits<TestSequenceCallback>::NativeValue(

scope.isolate(), v8::Undefined(scope.isolate()), exceptionState);

EXPECT_TRUE(exceptionState.hadException());

EXPECT_EQ("Unable to convert value to TestSequenceCallback.",