third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp b/third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp

index 7a4e55d54e1eb769aeab8405a551ce9171e3325b..9d1b64536a3df843af5e35ac13b3fd6c7b68fd14 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp

@@ -148,9 +148,9 @@ StringType v8StringToWebCoreString(v8::Local<v8::String> v8String,

// Explicitly instantiate the above template with the expected

// parameterizations, to ensure the compiler generates the code; otherwise link

// errors can result in GCC 4.4.

-template String v8StringToWebCoreString<String>(v8::Local<v8::String>,

+template String V8StringToWebCoreString<String>(v8::Local<v8::String>,

ExternalMode);

-template AtomicString v8StringToWebCoreString<AtomicString>(

+template AtomicString V8StringToWebCoreString<AtomicString>(

v8::Local<v8::String>,

ExternalMode);