Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2329463003: Remove unused instance field (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 4 chunks +4 lines, -12 lines 4 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-09-09 16:04:56 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2329463003/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/2329463003/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode1076 pkg/analyzer/lib/src/generated/incremental_resolver.dart:1076: ResolutionContextBuilder(); The documentation is not accurate anymore. And ...
4 years, 3 months ago (2016-09-09 16:06:53 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2329463003/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/2329463003/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode1076 pkg/analyzer/lib/src/generated/incremental_resolver.dart:1076: ResolutionContextBuilder(); Done https://codereview.chromium.org/2329463003/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode1178 pkg/analyzer/lib/src/generated/incremental_resolver.dart:1178: * [errorListener] - the listener ...
4 years, 3 months ago (2016-09-09 16:16:56 UTC) #4
Brian Wilkerson
4 years, 3 months ago (2016-09-09 16:17:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6abd185f93adf008f8410f92c5c5e6070d134f5c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698