Remove unused instance field

pkg/analyzer/lib/src/generated/incremental_resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.incremental_resolver;
 
 import 'dart:collection';
 import 'dart:math' as math;
 
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 313 matching lines @@
           node is MethodDeclaration) {
         return node;
       }
       node = node.parent;
     }
     throw new AnalysisException("Cannot resolve node: no resolvable node");
   }
 
   void _prepareResolutionContext(AstNode node) {
     if (_resolutionContext == null) {
-      _resolutionContext =
-          ResolutionContextBuilder.contextFor(node, errorListener);
+      _resolutionContext = ResolutionContextBuilder.contextFor(node);
     }
   }
 
   _resolveReferences(AstNode node) {
     LoggingTimer timer = logger.startTimer();
     try {
       _prepareResolutionContext(node);
       Scope scope = _resolutionContext.scope;
       // resolve types
       {
@@ skipping 701 matching lines @@
   Scope scope;
 }
 
 /**
  * Instances of the class [ResolutionContextBuilder] build the context for a
  * given node in an AST structure. At the moment, this class only handles
  * top-level and class-level declarations.
  */
 class ResolutionContextBuilder {
   /**
-   * The listener to which analysis errors will be reported.
-   */
-  final AnalysisErrorListener _errorListener;
-
-  /**
    * The class containing the enclosing [CompilationUnitElement].
    */
   CompilationUnitElement _enclosingUnit;
 
   /**
    * The class containing the enclosing [ClassDeclaration], or `null` if we are
    * not in the scope of a class.
    */
   ClassDeclaration _enclosingClassDeclaration;
 
   /**
    * The class containing the enclosing [ClassElement], or `null` if we are not
    * in the scope of a class.
    */
   ClassElement _enclosingClass;
 
   /**
    * Initialize a newly created scope builder to generate a scope that will
    * report errors to the given listener.
    */
-  ResolutionContextBuilder(this._errorListener);
+  ResolutionContextBuilder();

[scheglov, 2016/09/09 16:06:53]

The documentation is not accurate anymore.
And probably the whole constructor can be removed.

[Brian Wilkerson, 2016/09/09 16:16:56]

Done

 
   Scope _scopeFor(AstNode node) {
     if (node is CompilationUnit) {
       return _scopeForAstNode(node);
     }
     AstNode parent = node.parent;
     if (parent == null) {
       throw new AnalysisException(
           "Cannot create scope: node is not part of a CompilationUnit");
     }
@@ skipping 81 matching lines @@
       throw new AnalysisException(
           "Cannot create scope: compilation unit is not part of a library");
     }
     return new LibraryScope(libraryElement);
   }
 
   /**
    * Return the context in which the given AST structure should be resolved.
    *
    * [node] - the root of the AST structure to be resolved.
    * [errorListener] - the listener to which analysis errors will be reported.

[scheglov, 2016/09/09 16:06:53]

This line can be removed.

[Brian Wilkerson, 2016/09/09 16:16:56]

Done

    *
    * Throws [AnalysisException] if the AST structure has not been resolved or
    * is not part of a [CompilationUnit]
    */
-  static ResolutionContext contextFor(
-      AstNode node, AnalysisErrorListener errorListener) {
+  static ResolutionContext contextFor(AstNode node) {
     if (node == null) {
       throw new AnalysisException("Cannot create context: node is null");
     }
     // build scope
-    ResolutionContextBuilder builder =
-        new ResolutionContextBuilder(errorListener);
+    ResolutionContextBuilder builder = new ResolutionContextBuilder();
     Scope scope = builder._scopeFor(node);
     // prepare context
     ResolutionContext context = new ResolutionContext();
     context.scope = scope;
     context.enclosingUnit = builder._enclosingUnit;
     context.enclosingClassDeclaration = builder._enclosingClassDeclaration;
     context.enclosingClass = builder._enclosingClass;
     return context;
   }
 }
@@ skipping 112 matching lines @@
   @override
   String toString() => name;
 }
 
 class _TokenPair {
   final _TokenDifferenceKind kind;
   final Token oldToken;
   final Token newToken;
   _TokenPair(this.kind, this.oldToken, this.newToken);
 }