Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/resources/md_extensions/detail_view.js

Issue 2329443004: [MD Extensions] Implement opening tab-style options pages (Closed)
Patch Set: trailing comma Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_extensions/detail_view.js
diff --git a/chrome/browser/resources/md_extensions/detail_view.js b/chrome/browser/resources/md_extensions/detail_view.js
index c3b0afd930c0f76fdf6ebdb92ee0ab234da9d677..cdfe775b5f7a620b2ed727c50a3321bbe92b780a 100644
--- a/chrome/browser/resources/md_extensions/detail_view.js
+++ b/chrome/browser/resources/md_extensions/detail_view.js
@@ -52,6 +52,14 @@ cr.define('extensions', function() {
* @return {boolean}
* @private
*/
+ shouldShowOptionsButton_: function() {
+ return !!this.data.optionsPage;
+ },
+
+ /**
+ * @return {boolean}
+ * @private
+ */
shouldShowOptionsSection_: function() {
return this.data.incognitoAccess.isEnabled ||
this.data.fileAccess.isEnabled ||
@@ -60,6 +68,11 @@ cr.define('extensions', function() {
},
/** @private */
+ onOptionsButtonClick_: function() {
+ this.delegate.showItemOptionsPage(this.data.id);
+ },
+
+ /** @private */
onAllowIncognitoChange_: function() {
this.delegate.setItemAllowedIncognito(
this.data.id, this.$$('#allow-incognito').checked);

Powered by Google App Engine
This is Rietveld 408576698