Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3756)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/md_extensions/detail_view.html

Issue 2329443004: [MD Extensions] Implement opening tab-style options pages (Closed)
Patch Set: trailing comma Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/md_extensions/detail_view.js » ('j') | chrome/test/data/webui/extensions/extension_detail_view_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_extensions/detail_view.html
diff --git a/chrome/browser/resources/md_extensions/detail_view.html b/chrome/browser/resources/md_extensions/detail_view.html
index 9b5468875bcace9edf8efca7db077143bcdbe218..d6856776c31fa798f52a67ecf1d13555ec4d2861 100644
--- a/chrome/browser/resources/md_extensions/detail_view.html
+++ b/chrome/browser/resources/md_extensions/detail_view.html
@@ -13,6 +13,9 @@
<style include="iron-flex"></style>
<template>
<style>
+ [hidden] {
+ display: none !important;
+ }
#main {
background-color: white;
height: 800px;
@@ -63,7 +66,9 @@
<span id="name">[[data.name]]</span>
<paper-icon-button id="open-in-webstore" icon="open-in-new">
</paper-icon-button>
- <paper-icon-button id="options" icon="settings">
+ <paper-icon-button id="options" icon="settings"
+ on-click="onOptionsButtonClick_"
michaelpg 2016/09/15 02:13:46 on-tap
Devlin 2016/09/15 16:42:17 Done.
+ hidden$="[[!shouldShowOptionsButton_(data.*)]]">
</paper-icon-button>
</div>
<div class="section">
« no previous file with comments | « no previous file | chrome/browser/resources/md_extensions/detail_view.js » ('j') | chrome/test/data/webui/extensions/extension_detail_view_test.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698