Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2329373002: V8: Log captured MB output in case of failure (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Test case #

Patch Set 3 : Remove test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M scripts/slave/recipe_modules/v8/api.py View 1 chunk +15 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Achenbach
TBR - an fyi test case in patch 2 shows the behavior. But I don't ...
4 years, 3 months ago (2016-09-12 07:17:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329373002/40001
4 years, 3 months ago (2016-09-12 07:17:44 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/build/+/933e300108316ef674958e1aefa1350847c5db90
4 years, 3 months ago (2016-09-12 07:21:22 UTC) #7
Michael Achenbach
In prod it turns this: https://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/24272 into this: https://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/24283
4 years, 3 months ago (2016-09-12 07:32:06 UTC) #8
tandrii(chromium)
4 years, 3 months ago (2016-09-12 08:33:49 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698