Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 2329373002: V8: Log captured MB output in case of failure (Closed)
Patch Set: Remove test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/api.py
diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py
index 62a3547628f8609c066a2afe485698474a31fb37..68e200c0d02ed199eac73929ab8096499c42537a 100644
--- a/scripts/slave/recipe_modules/v8/api.py
+++ b/scripts/slave/recipe_modules/v8/api.py
@@ -456,19 +456,21 @@ class V8Api(recipe_api.RecipeApi):
'GYP_DEFINES=\'target_arch=x64 cool_flag=a=1\'\n'
'moar\n'
)
- self.m.chromium.run_mb(
- self.m.properties['mastername'],
- self.m.properties['buildername'],
- use_goma=use_goma,
- mb_config_path=self.m.path['checkout'].join(
- 'infra', 'mb', 'mb_config.pyl'),
- gyp_script=self.m.path.join('gypfiles', 'gyp_v8'),
- stdout=self.m.raw_io.output(),
- step_test_data=step_test_data,
- )
- # Log captured output.
- self.m.step.active_result.presentation.logs['stdout'] = (
- self.m.step.active_result.stdout.splitlines())
+ try:
+ self.m.chromium.run_mb(
+ self.m.properties['mastername'],
+ self.m.properties['buildername'],
+ use_goma=use_goma,
+ mb_config_path=self.m.path['checkout'].join(
+ 'infra', 'mb', 'mb_config.pyl'),
+ gyp_script=self.m.path.join('gypfiles', 'gyp_v8'),
+ stdout=self.m.raw_io.output(),
+ step_test_data=step_test_data,
+ )
+ finally:
+ # Log captured output.
+ self.m.step.active_result.presentation.logs['stdout'] = (
+ self.m.step.active_result.stdout.splitlines())
# Update the build environment dictionary, which is printed to the
# user on test failures for easier build reproduction.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698