Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 23292002: Don't expose document.register to Chrome Apps by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweak RegisterElement Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index 47509d2b07da56f5ccb7f43dac72992ea44717e8..48bd355c1ce95567e8b062ade4d96226ca5e8e03 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -72,6 +72,7 @@
#include "chrome/renderer/extensions/user_script_slave.h"
#include "chrome/renderer/extensions/web_request_custom_bindings.h"
#include "chrome/renderer/extensions/webstore_bindings.h"
+#include "chrome/renderer/extensions/webview_custom_bindings.h"
#include "chrome/renderer/resource_bundle_source_map.h"
#include "content/public/renderer/render_thread.h"
#include "content/public/renderer/render_view.h"
@@ -891,6 +892,9 @@ void Dispatcher::RegisterNativeHandlers(ModuleSystem* module_system,
new WebRequestCustomBindings(this, context)));
module_system->RegisterNativeHandler("webstore",
scoped_ptr<NativeHandler>(new WebstoreBindings(this, context)));
+ module_system->RegisterNativeHandler("webview_natives",
dominicc (has gone to gerrit) 2013/08/17 00:13:12 Assuming subsequent *views, or even something else
Fady Samuel 2013/08/20 23:00:39 Agreed. Moved to document_natives.
+ scoped_ptr<NativeHandler>(
+ new WebviewCustomBindings(this, context)));
}
void Dispatcher::PopulateSourceMap() {
@@ -1290,11 +1294,11 @@ void Dispatcher::AddOrRemoveOriginPermissions(
}
void Dispatcher::EnableCustomElementWhiteList() {
- WebKit::WebRuntimeFeatures::enableCustomElements(true);
- WebKit::WebCustomElement::allowTagName("webview");
+ WebKit::WebRuntimeFeatures::enableEmbedderElements(true);
dominicc (has gone to gerrit) 2013/08/17 00:13:12 FYI in response to code review feedback on the Bli
Fady Samuel 2013/08/20 23:00:39 Done.
+ WebKit::WebCustomElement::addEmbedderElementName("webview");
// TODO(fsamuel): Add <adview> to the whitelist once it has been converted
// into a custom element.
- WebKit::WebCustomElement::allowTagName("browser-plugin");
+ WebKit::WebCustomElement::addEmbedderElementName("browser-plugin");
}
void Dispatcher::AddOrRemoveBindings(const std::string& extension_id) {

Powered by Google App Engine
This is Rietveld 408576698