Don't expose document.register to Chrome Apps by default.

chrome/renderer/extensions/dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/dispatcher.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/debug/alias.h"
 #include "base/json/json_reader.h"
@@ skipping 54 matching lines @@
 #include "chrome/renderer/extensions/safe_builtins.h"
 #include "chrome/renderer/extensions/send_request_natives.h"
 #include "chrome/renderer/extensions/set_icon_natives.h"
 #include "chrome/renderer/extensions/sync_file_system_custom_bindings.h"
 #include "chrome/renderer/extensions/tab_finder.h"
 #include "chrome/renderer/extensions/tabs_custom_bindings.h"
 #include "chrome/renderer/extensions/tts_custom_bindings.h"
 #include "chrome/renderer/extensions/user_script_slave.h"
 #include "chrome/renderer/extensions/web_request_custom_bindings.h"
 #include "chrome/renderer/extensions/webstore_bindings.h"
+#include "chrome/renderer/extensions/webview_custom_bindings.h"
 #include "chrome/renderer/resource_bundle_source_map.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "content/public/renderer/v8_value_converter.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/features/feature_provider.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/view_type.h"
 #include "grit/common_resources.h"
 #include "grit/renderer_resources.h"
@@ skipping 799 matching lines @@
       scoped_ptr<NativeHandler>(new RuntimeCustomBindings(this, context)));
   module_system->RegisterNativeHandler("tabs",
       scoped_ptr<NativeHandler>(new TabsCustomBindings(this, context)));
   module_system->RegisterNativeHandler("tts",
       scoped_ptr<NativeHandler>(new TTSCustomBindings(this, context)));
   module_system->RegisterNativeHandler("web_request",
       scoped_ptr<NativeHandler>(
           new WebRequestCustomBindings(this, context)));
   module_system->RegisterNativeHandler("webstore",
       scoped_ptr<NativeHandler>(new WebstoreBindings(this, context)));
+  module_system->RegisterNativeHandler("webview_natives",

[dominicc (has gone to gerrit), 2013/08/17 00:13:12]

Assuming subsequent *views, or even something else, use Custom Elements; does it
make sense to give this extension and class a more generic name that reflects
what it does and not who uses it?

I admit there's a certain pedagogy in naming the thing after who uses it...
WDYT?

[Fady Samuel, 2013/08/20 23:00:39]

Agreed. Moved to document_natives.

+      scoped_ptr<NativeHandler>(
+          new WebviewCustomBindings(this, context)));
 }
 
 void Dispatcher::PopulateSourceMap() {
   // Libraries.
   source_map_.RegisterSource("contentWatcher", IDR_CONTENT_WATCHER_JS);
   source_map_.RegisterSource("entryIdManager", IDR_ENTRY_ID_MANAGER);
   source_map_.RegisterSource(kEventModule, IDR_EVENT_BINDINGS_JS);
   source_map_.RegisterSource("imageUtil", IDR_IMAGE_UTIL_JS);
   source_map_.RegisterSource("json_schema", IDR_JSON_SCHEMA_JS);
   source_map_.RegisterSource("lastError", IDR_LAST_ERROR_JS);
@@ skipping 379 matching lines @@
               extension->url(),
               WebString::fromUTF8(schemes[j]),
               WebString::fromUTF8(i->host()),
               i->match_subdomains());
       }
     }
   }
 }
 
 void Dispatcher::EnableCustomElementWhiteList() {
-  WebKit::WebRuntimeFeatures::enableCustomElements(true);
-  WebKit::WebCustomElement::allowTagName("webview");
+  WebKit::WebRuntimeFeatures::enableEmbedderElements(true);

[dominicc (has gone to gerrit), 2013/08/17 00:13:12]

FYI in response to code review feedback on the Blink-side patch, EmbedderElement
-> EmbedderCustomElement everywhere it appears.

[Fady Samuel, 2013/08/20 23:00:39]

Done.

+  WebKit::WebCustomElement::addEmbedderElementName("webview");
   // TODO(fsamuel): Add <adview> to the whitelist once it has been converted
   // into a custom element.
-  WebKit::WebCustomElement::allowTagName("browser-plugin");
+  WebKit::WebCustomElement::addEmbedderElementName("browser-plugin");
 }
 
 void Dispatcher::AddOrRemoveBindings(const std::string& extension_id) {
   v8_context_set().ForEach(
       extension_id,
       NULL,  // all render views
       base::Bind(&Dispatcher::AddOrRemoveBindingsForContext,
                  base::Unretained(this)));
 }
 
@@ skipping 249 matching lines @@
     RenderView* background_view =
         ExtensionHelper::GetBackgroundPage(extension_id);
     if (background_view) {
       background_view->Send(new ExtensionHostMsg_EventAck(
           background_view->GetRoutingID()));
     }
   }
 }
 
 }  // namespace extensions