Don't expose document.register to Chrome Apps by default.

Don't expose document.register to Chrome Apps by default.

This CL doesn't expose document.register by default to Chrome Apps.

Instead, DocumentNatives.RegisterElement is exposed to web_view.js in
order to register webview as a custom element.

This CL depends on Dominic's CL: http://crrev.com/22854017

BUG=273126
Test=manually, <webview> still works.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218769

[dominicc (has gone to gerrit), 2013-08-17 00:13:12]

Some DBCs and FYIs.

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/extensions...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/extensions...
chrome/renderer/extensions/dispatcher.cc:895:
module_system->RegisterNativeHandler("webview_natives",
Assuming subsequent *views, or even something else, use Custom Elements; does it
make sense to give this extension and class a more generic name that reflects
what it does and not who uses it?

I admit there's a certain pedagogy in naming the thing after who uses it...
WDYT?

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/extensions...
chrome/renderer/extensions/dispatcher.cc:1297:
WebKit::WebRuntimeFeatures::enableEmbedderElements(true);
FYI in response to code review feedback on the Blink-side patch, EmbedderElement
-> EmbedderCustomElement everywhere it appears.

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/extensions...
File chrome/renderer/extensions/webview_custom_bindings.h (right):

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/extensions...
chrome/renderer/extensions/webview_custom_bindings.h:12: // Implements custom
bindings for the webRequest API.
Not webrequest.

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/resources/...
File chrome/renderer/resources/extensions/web_view.js (right):

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/resources/...
chrome/renderer/resources/extensions/web_view.js:705: // Save document.register
in a variable in case the developer attempts to
This comment can go now. No author is going to override you now.

[dominicc (has gone to gerrit), 2013-08-17 00:15:20]

One more nit--CL description, the Blink side patch is 22*8*54017.

[Fady Samuel, 2013-08-20 23:00:39]

+dominicc@ PTAL
+mpcomplete@ for OWNER review.

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/extensions...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/extensions...
chrome/renderer/extensions/dispatcher.cc:895:
module_system->RegisterNativeHandler("webview_natives",
On 2013/08/17 00:13:12, dominicc wrote:
> Assuming subsequent *views, or even something else, use Custom Elements; does
it
> make sense to give this extension and class a more generic name that reflects
> what it does and not who uses it?
> 
> I admit there's a certain pedagogy in naming the thing after who uses it...
> WDYT?

Agreed. Moved to document_natives.

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/extensions...
chrome/renderer/extensions/dispatcher.cc:1297:
WebKit::WebRuntimeFeatures::enableEmbedderElements(true);
On 2013/08/17 00:13:12, dominicc wrote:
> FYI in response to code review feedback on the Blink-side patch,
EmbedderElement
> -> EmbedderCustomElement everywhere it appears.

Done.

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/extensions...
File chrome/renderer/extensions/webview_custom_bindings.h (right):

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/extensions...
chrome/renderer/extensions/webview_custom_bindings.h:12: // Implements custom
bindings for the webRequest API.
On 2013/08/17 00:13:12, dominicc wrote:
> Not webrequest.

Done.

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/resources/...
File chrome/renderer/resources/extensions/web_view.js (right):

https://codereview.chromium.org/23292002/diff/5001/chrome/renderer/resources/...
chrome/renderer/resources/extensions/web_view.js:705: // Save document.register
in a variable in case the developer attempts to
On 2013/08/17 00:13:12, dominicc wrote:
> This comment can go now. No author is going to override you now.

Done.

[Matt Perry, 2013-08-20 23:10:24]

couple small changes, then lgtm

https://codereview.chromium.org/23292002/diff/12001/chrome/renderer/extension...
File chrome/renderer/extensions/document_custom_bindings.cc (right):

https://codereview.chromium.org/23292002/diff/12001/chrome/renderer/extension...
chrome/renderer/extensions/document_custom_bindings.cc:37: NOTREACHED();
I think both render_view and web_view can legitimately be NULL in some cases.
Don't NOTREACHED for them.

https://codereview.chromium.org/23292002/diff/12001/chrome/renderer/extension...
chrome/renderer/extensions/document_custom_bindings.cc:47: if
(!args[0]->IsString() || !args[1]->IsObject()) {
nit: combine this with the previous if

https://codereview.chromium.org/23292002/diff/12001/chrome/renderer/extension...
File chrome/renderer/extensions/document_custom_bindings.h (right):

https://codereview.chromium.org/23292002/diff/12001/chrome/renderer/extension...
chrome/renderer/extensions/document_custom_bindings.h:18: void
RegisterElement(const v8::FunctionCallbackInfo<v8::Value>& args);
document this method

[dominicc (has gone to gerrit), 2013-08-20 23:25:31]

lgtm

[Fady Samuel, 2013-08-21 11:47:23]

Addressed all comments, Blink has rolled past the Blink-side CL. CQ'ing now.

https://codereview.chromium.org/23292002/diff/12001/chrome/renderer/extension...
File chrome/renderer/extensions/document_custom_bindings.cc (right):

https://codereview.chromium.org/23292002/diff/12001/chrome/renderer/extension...
chrome/renderer/extensions/document_custom_bindings.cc:37: NOTREACHED();
On 2013/08/20 23:10:24, Matt Perry wrote:
> I think both render_view and web_view can legitimately be NULL in some cases.
> Don't NOTREACHED for them.

Done.

https://codereview.chromium.org/23292002/diff/12001/chrome/renderer/extension...
chrome/renderer/extensions/document_custom_bindings.cc:47: if
(!args[0]->IsString() || !args[1]->IsObject()) {
On 2013/08/20 23:10:24, Matt Perry wrote:
> nit: combine this with the previous if

Done.

https://codereview.chromium.org/23292002/diff/12001/chrome/renderer/extension...
File chrome/renderer/extensions/document_custom_bindings.h (right):

https://codereview.chromium.org/23292002/diff/12001/chrome/renderer/extension...
chrome/renderer/extensions/document_custom_bindings.h:18: void
RegisterElement(const v8::FunctionCallbackInfo<v8::Value>& args);
On 2013/08/20 23:10:24, Matt Perry wrote:
> document this method

Done.

[commit-bot: I haz the power, 2013-08-21 11:48:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/23292002/13006

[commit-bot: I haz the power, 2013-08-21 17:28:12]

Change committed as 218769