Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client.cc

Issue 2329153002: Remove the WARNING security level.
Patch Set: Update Android test to take into account HTTPS scheme coloring. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_security_state_model_client.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client.cc b/chrome/browser/ssl/chrome_security_state_model_client.cc
index 1fe022041d1d764b4596f6270ba8fd620b6cb33d..604d45ab6bf498e8329e7b22e7f8428c27989cf8 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client.cc
@@ -55,10 +55,6 @@ SecurityStateModel::SecurityLevel GetSecurityLevelForSecurityStyle(
return SecurityStateModel::NONE;
case content::SECURITY_STYLE_AUTHENTICATION_BROKEN:
return SecurityStateModel::SECURITY_ERROR;
- case content::SECURITY_STYLE_WARNING:
- // content currently doesn't use this style.
- NOTREACHED();
- return SecurityStateModel::SECURITY_WARNING;
case content::SECURITY_STYLE_AUTHENTICATED:
return SecurityStateModel::SECURE;
}
@@ -72,10 +68,8 @@ content::SecurityStyle SecurityLevelToSecurityStyle(
SecurityStateModel::SecurityLevel security_level) {
switch (security_level) {
case SecurityStateModel::NONE:
- return content::SECURITY_STYLE_UNAUTHENTICATED;
- case SecurityStateModel::SECURITY_WARNING:
case SecurityStateModel::SECURITY_POLICY_WARNING:
- return content::SECURITY_STYLE_WARNING;
+ return content::SECURITY_STYLE_UNAUTHENTICATED;
estark 2016/09/14 01:21:54 Hrmm, this means that we'll show "This page is not
case SecurityStateModel::EV_SECURE:
case SecurityStateModel::SECURE:
return content::SECURITY_STYLE_AUTHENTICATED;

Powered by Google App Engine
This is Rietveld 408576698