Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

Issue 2329153002: Remove the WARNING security level.
Patch Set: Update Android test to take into account HTTPS scheme coloring. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java
index b0b704230bfdf7db39b81d8ff2d35250337d0432..e7226cfca2e05fc656d6c704eb33d6f358dafe13 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java
@@ -46,8 +46,6 @@ public class WebappVisibilityTest extends NativeLibraryTestBase {
assertFalse(shouldShowTopControls(WEBAPP_URL, "", ConnectionSecurityLevel.NONE));
// Show top controls for non secure URLs.
- assertTrue(shouldShowTopControls(WEBAPP_URL, "http://sub.originalwebsite.com",
estark 2016/09/14 01:21:54 I'm wondering if having a test for sub.originalweb
lgarron 2016/09/19 22:15:51 Good idea; done.
- ConnectionSecurityLevel.SECURITY_WARNING));
assertTrue(shouldShowTopControls(WEBAPP_URL, "http://notoriginalwebsite.com",
ConnectionSecurityLevel.SECURITY_ERROR));
assertTrue(shouldShowTopControls(
@@ -55,11 +53,11 @@ public class WebappVisibilityTest extends NativeLibraryTestBase {
assertTrue(shouldShowTopControls(WEBAPP_URL, "http://thing.originalwebsite.com",
ConnectionSecurityLevel.SECURITY_ERROR));
assertTrue(shouldShowTopControls(
- WEBAPP_URL, WEBAPP_URL, ConnectionSecurityLevel.SECURITY_WARNING));
+ WEBAPP_URL, WEBAPP_URL, ConnectionSecurityLevel.SECURITY_ERROR));
assertTrue(shouldShowTopControls(
- WEBAPP_URL, WEBAPP_URL + "/things.html", ConnectionSecurityLevel.SECURITY_WARNING));
+ WEBAPP_URL, WEBAPP_URL + "/things.html", ConnectionSecurityLevel.SECURITY_ERROR));
assertTrue(shouldShowTopControls(
- WEBAPP_URL, WEBAPP_URL + "/stuff.html", ConnectionSecurityLevel.SECURITY_WARNING));
+ WEBAPP_URL, WEBAPP_URL + "/stuff.html", ConnectionSecurityLevel.SECURITY_ERROR));
}
/**

Powered by Google App Engine
This is Rietveld 408576698