Chromium Code Reviews| Index: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java |
| diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java |
| index 8668eef13352b6e0dd87ad3559f58140e9ad237e..e5731895226867a8318a4983e7a5d34bfc777255 100644 |
| --- a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java |
| +++ b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java |
| @@ -191,24 +191,25 @@ public class OmniboxUrlEmphasizerTest extends NativeLibraryTestBase { |
| } |
| /** |
| - * Verify that a very short, warning HTTPS URL is colored correctly by |
| + * Verify that a short, insecure HTTPS URL is colored correctly by |
| * OmniboxUrlEmphasizer.emphasizeUrl(). |
| */ |
| @UiThreadTest |
| @MediumTest |
| @Feature({"Browser", "Main"}) |
| - public void testVeryShortWarningHTTPSUrl() { |
| + public void testShortWarningHTTPSUrl() { |
|
estark
2016/09/14 01:21:54
This rename looks like it changed the wrong thing,
lgarron
2016/09/19 22:15:50
My best guess is that the existing code used "very
|
| Spannable url = new SpannableStringBuilder("https://www.dodgysite.com"); |
| OmniboxUrlEmphasizer.emphasizeUrl(url, mResources, mProfile, |
| - ConnectionSecurityLevel.SECURITY_WARNING, false, true, true); |
| + ConnectionSecurityLevel.SECURITY_ERROR, false, true, true); |
| EmphasizedUrlSpanHelper[] spans = EmphasizedUrlSpanHelper.getSpansForEmphasizedUrl(url); |
| - assertEquals("Unexpected number of spans:", 3, spans.length); |
| - spans[0].assertIsColoredSpan("https", 0, ApiCompatibilityUtils.getColor(mResources, |
| - R.color.url_emphasis_non_emphasized_text)); |
| - spans[1].assertIsColoredSpan("://", 5, ApiCompatibilityUtils.getColor(mResources, |
| + assertEquals("Unexpected number of spans:", 4, spans.length); |
| + spans[0].assertIsStrikethroughSpan("https", 0); |
| + spans[1].assertIsColoredSpan("https", 0, ApiCompatibilityUtils.getColor(mResources, |
| + R.color.google_red_700)); |
| + spans[2].assertIsColoredSpan("://", 5, ApiCompatibilityUtils.getColor(mResources, |
| R.color.url_emphasis_non_emphasized_text)); |
| - spans[2].assertIsColoredSpan( |
| + spans[3].assertIsColoredSpan( |
| "www.dodgysite.com", 8, ApiCompatibilityUtils.getColor(mResources, |
| R.color.url_emphasis_domain_and_registry)); |
| } |