Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2328843003: [x64] supplement SSE insturctions for SIMD.js (Closed)

Created:
4 years, 3 months ago by Weiliang
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] supplement SSE insturctions for SIMD.js Both legacy and AVX versions BUG= Committed: https://crrev.com/e151c66013a333801d02554dd2b358ce9805a6ab Cr-Commit-Position: refs/heads/master@{#39327}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+763 lines, -135 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 9 chunks +219 lines, -41 lines 0 comments Download
M src/x64/assembler-x64.cc View 13 chunks +204 lines, -74 lines 0 comments Download
M src/x64/disasm-x64.cc View 13 chunks +199 lines, -14 lines 0 comments Download
A src/x64/sse-instr.h View 1 chunk +69 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 7 chunks +68 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Weiliang
PTAL
4 years, 3 months ago (2016-09-09 07:06:16 UTC) #2
Benedikt Meurer
LGTM, thanks.
4 years, 3 months ago (2016-09-12 04:43:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328843003/20001
4 years, 3 months ago (2016-09-12 05:58:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 06:24:14 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 06:25:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e151c66013a333801d02554dd2b358ce9805a6ab
Cr-Commit-Position: refs/heads/master@{#39327}

Powered by Google App Engine
This is Rietveld 408576698