Add workaround for Adreno copyImageToBuffer calls on Vulkan

Add workaround for Adreno copyImageToBuffer calls on Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328823003

Committed: https://skia.googlesource.com/skia/+/6fa0a91e607343a244a8789669d3fd15a98f80f7

[egdaniel, 2016-09-09 13:38:24]

Description was changed from

==========
Add workaround for Adreno copyImageToBuffer calls on Vulkan

BUG=skia:
==========

to

==========
Add workaround for Adreno copyImageToBuffer calls on Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328823003
==========

[egdaniel, 2016-09-09 13:50:55]

egdaniel@google.com changed reviewers:
+ brianosman@google.com, jvanverth@google.com

[egdaniel, 2016-09-09 13:50:55]

So this works around the bug I've been having with Adreno read pixels which was
causing many tests to fail. The basic work around is to always read from the
origin and then just copy over the data we care about. Please try and double
check the logic here since its very easy to make a subtle mistake...

Our CopySurface test is still failing, which I think could be a related issue
since it also involve a imageOffset parameter, but still need to investigate to
confirm. However, that one may be a lot harder to fix given I can't copy extra
data into the image...

[Brian Osman, 2016-09-09 18:57:50]

lgtm

https://codereview.chromium.org/2328823003/diff/1/src/gpu/vk/GrVkCaps.h
File src/gpu/vk/GrVkCaps.h (right):

https://codereview.chromium.org/2328823003/diff/1/src/gpu/vk/GrVkCaps.h#newco...
src/gpu/vk/GrVkCaps.h:118: // On Adreno vulkan, they do no respect the
imageOffset parameter at least ing
s/no/not/ ... s/ing/in/

[egdaniel, 2016-09-12 16:24:10]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-09-12 16:24:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianosman@google.com
Link to the patchset: https://codereview.chromium.org/2328823003/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-09-12 16:24:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 18:51:35]

Description was changed from

==========
Add workaround for Adreno copyImageToBuffer calls on Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328823003
==========

to

==========
Add workaround for Adreno copyImageToBuffer calls on Vulkan

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328823003

Committed:
https://skia.googlesource.com/skia/+/6fa0a91e607343a244a8789669d3fd15a98f80f7
==========

[commit-bot: I haz the power, 2016-09-12 18:51:37]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6fa0a91e607343a244a8789669d3fd15a98f80f7