Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2328803002: Run Physical Web background subscription (Closed)

Created:
4 years, 3 months ago by cco3
Modified:
4 years, 3 months ago
Reviewers:
gone, mattreynolds
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Run Physical Web background subscription In the transition to use a new class for subscriptions, the background subscription got dropped because it wasn't actually run. This change actually performs the subscription. BUG=623638, 645182 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2316413002 Cr-Commit-Position: refs/heads/master@{#417410} (cherry picked from commit 8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0)

Patch Set 1 #

Patch Set 2 : Update commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
gone
Did you need me to lgtm the cherry-pick?
4 years, 3 months ago (2016-09-09 17:07:30 UTC) #3
gone
Which I guess I just gave anyway. lol
4 years, 3 months ago (2016-09-09 17:07:57 UTC) #4
cco3
On 2016/09/09 17:07:57, dfalcantara wrote: > Which I guess I just gave anyway. lol Yes...I'll ...
4 years, 3 months ago (2016-09-09 17:21:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328803002/1
4 years, 3 months ago (2016-09-09 20:53:38 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-09 20:53:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328803002/20001
4 years, 3 months ago (2016-09-09 21:03:34 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 21:06:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698