Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2316413002: Run Physical Web background subscription (Closed)

Created:
4 years, 3 months ago by cco3
Modified:
4 years, 3 months ago
Reviewers:
gone, mattreynolds
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run Physical Web background subscription In the transition to use a new class for subscriptions, the background subscription got dropped because it wasn't actually run. This change actually performs the subscription. BUG=623638, 645182 Committed: https://crrev.com/8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0 Cr-Commit-Position: refs/heads/master@{#417410}

Patch Set 1 #

Patch Set 2 : Update bug IDs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
mattreynolds
lgtm
4 years, 3 months ago (2016-09-08 17:39:57 UTC) #3
cco3
4 years, 3 months ago (2016-09-08 17:45:38 UTC) #5
gone
lgtm
4 years, 3 months ago (2016-09-08 20:07:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316413002/20001
4 years, 3 months ago (2016-09-08 20:37:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 21:56:50 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 21:58:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0
Cr-Commit-Position: refs/heads/master@{#417410}

Powered by Google App Engine
This is Rietveld 408576698