Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2328703002: Get rid of "Open in Chrome" from EmbedContentViewActivity (Closed)

Created:
4 years, 3 months ago by gone
Modified:
4 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of "Open in Chrome" from EmbedContentViewActivity Discussion resulted in zero-ish cases where this would be useful. BUG=644848 Committed: https://crrev.com/5407ae12413f9dd3edc4b4a4574786ed8c01901d Cr-Commit-Position: refs/heads/master@{#417370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
gone
4 years, 3 months ago (2016-09-08 18:40:33 UTC) #2
Ted C
lgtm
4 years, 3 months ago (2016-09-08 18:45:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328703002/1
4 years, 3 months ago (2016-09-08 18:46:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 19:53:58 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 19:56:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5407ae12413f9dd3edc4b4a4574786ed8c01901d
Cr-Commit-Position: refs/heads/master@{#417370}

Powered by Google App Engine
This is Rietveld 408576698