Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java

Issue 2328703002: Get rid of "Open in Chrome" from EmbedContentViewActivity (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java
index 842510bd3b99ecb1962b1b57e17894362e2986a8..b7a283fa0d6eeb35d4e2e5bf12f0334c81e49c13 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java
@@ -8,11 +8,9 @@ import android.app.ActionBar;
import android.app.Activity;
import android.content.Context;
import android.content.Intent;
-import android.net.Uri;
import android.view.Menu;
import android.view.MenuItem;
-import org.chromium.chrome.R;
import org.chromium.chrome.browser.firstrun.FirstRunStatus;
import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
import org.chromium.chrome.browser.tab.Tab;
@@ -91,7 +89,6 @@ public class EmbedContentViewActivity extends FullScreenActivity {
public boolean onCreateOptionsMenu(Menu menu) {
boolean retVal = super.onCreateOptionsMenu(menu);
if (!FirstRunStatus.getFirstRunFlowComplete(this)) return retVal;
- menu.add(Menu.NONE, R.id.menu_id_open_in_chrome, Menu.NONE, R.string.menu_open_in_chrome);
return true;
}
@@ -102,13 +99,6 @@ public class EmbedContentViewActivity extends FullScreenActivity {
// Handles up navigation
finish();
return true;
- } else if (itemId == R.id.menu_id_open_in_chrome && getActivityTab() != null) {
- Intent chromeIntent = new Intent(
- Intent.ACTION_VIEW, Uri.parse(getActivityTab().getUrl()));
- chromeIntent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
- IntentHandler.startChromeLauncherActivityForTrustedIntent(
- chromeIntent, getApplicationContext());
- return true;
}
return super.onOptionsItemSelected(item);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698