Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: src/ast/ast-value-factory.h

Issue 2328593002: [Parser] Don't internalize on-the-fly. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/ast-value-factory.cc » ('j') | src/parsing/rewriter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast-value-factory.h
diff --git a/src/ast/ast-value-factory.h b/src/ast/ast-value-factory.h
index 39bb2a176f5325668039b9528f5a2d668e608359..552b141695b6715a701804a1dc60b9a0fe733dc1 100644
--- a/src/ast/ast-value-factory.h
+++ b/src/ast/ast-value-factory.h
@@ -327,7 +327,6 @@ class AstValueFactory {
values_(nullptr),
strings_end_(&strings_),
zone_(zone),
- isolate_(NULL),
hash_seed_(hash_seed) {
ResetStrings();
#define F(name, str) name##_string_ = NULL;
@@ -355,9 +354,6 @@ class AstValueFactory {
const AstString* right);
void Internalize(Isolate* isolate);
- bool IsInternalized() {
- return isolate_ != NULL;
- }
#define F(name, str) \
const AstRawString* name##_string() { \
@@ -385,21 +381,13 @@ class AstValueFactory {
private:
AstValue* AddValue(AstValue* value) {
- if (isolate_) {
- value->Internalize(isolate_);
- } else {
- value->set_next(values_);
- values_ = value;
- }
+ value->set_next(values_);
+ values_ = value;
return value;
}
AstString* AddString(AstString* string) {
- if (isolate_) {
- string->Internalize(isolate_);
- } else {
- *strings_end_ = string;
- strings_end_ = string->next_location();
- }
+ *strings_end_ = string;
+ strings_end_ = string->next_location();
return string;
}
void ResetStrings() {
@@ -423,7 +411,6 @@ class AstValueFactory {
AstString* strings_;
AstString** strings_end_;
Zone* zone_;
- Isolate* isolate_;
uint32_t hash_seed_;
« no previous file with comments | « no previous file | src/ast/ast-value-factory.cc » ('j') | src/parsing/rewriter.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698