[Parser] Don't internalize on-the-fly.

src/parsing/rewriter.cc

Index: src/parsing/rewriter.cc
diff --git a/src/parsing/rewriter.cc b/src/parsing/rewriter.cc
index 51ff547017ef2cec0b08a11d908ff8c5eb4576fb..57009bd20707af3260e2e6e367d72eef374dffb6 100644
--- a/src/parsing/rewriter.cc
+++ b/src/parsing/rewriter.cc
@@ -347,10 +347,13 @@ bool Rewriter::Rewrite(ParseInfo* info) {
     Variable* result = closure_scope->NewTemporary(
         info->ast_value_factory()->dot_result_string());
     // The name string must be internalized at this point.
+    info->ast_value_factory()->Internalize(info->isolate());

[marja, 2016/09/12 07:21:48]

Is this needed? Isn't the name internalized at this point anyway?

[rmcilroy, 2016/09/20 08:50:46]

Yeah this is needed. The "dot_result_string" needs to be internalized before
running the processor, and it isn't at this point unless something in the parser
referenced it.

     DCHECK(!result->name().is_null());
     Processor processor(info->isolate(), closure_scope, result,
                         info->ast_value_factory());
     processor.Process(body);
+    // Internalize any values created during rewriting.
+    info->ast_value_factory()->Internalize(info->isolate());
     if (processor.HasStackOverflow()) return false;
 
     if (processor.result_assigned()) {