third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h - Issue 2328463004: Implement WebGL's commit on the main thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

Issue 2328463004: Implement WebGL's commit on the main thread (Closed)

Patch Set: address junov@'s comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp ('K') | « third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h ('k') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp » ('j') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

diff --git a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

index 33ea9da2a4b7fc14b74c3925ced02916b56e582e..0c6d4b7589c8db255081d56ce42fb7faebbe6d03 100644

--- a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

+++ b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

@@ -18,7 +18,7 @@ public:

// OffscreenCanvasFrameDispatcher implementation.

~OffscreenCanvasFrameDispatcherImpl() override {}

- void dispatchFrame() override;

+ void dispatchFrame(PassRefPtr<StaticBitmapImage>) override;

danakj 2016/09/09 20:51:42 Are we still using PassRefPtr in new code or shoul

private:

const cc::SurfaceId m_surfaceId;