third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp - Issue 2328463004: Implement WebGL's commit on the main thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

Issue 2328463004: Implement WebGL's commit on the main thread (Closed)

Patch Set: address junov@'s comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h ('K') | « third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h ('k') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h » ('j') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp b/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

index 28b72be0fd4be892ea2765f5bd3bf0ca5b1f087d..8541d13a01619be3db87a56a16426d6ab082ec03 100644

--- a/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

+++ b/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp

@@ -28,9 +28,9 @@ PassRefPtr<AcceleratedStaticBitmapImage> AcceleratedStaticBitmapImage::createFro

return adoptRef(new AcceleratedStaticBitmapImage(std::move(image)));

}

-PassRefPtr<AcceleratedStaticBitmapImage> AcceleratedStaticBitmapImage::createFromWebGLContextImage(sk_sp<SkImage> image, const gpu::Mailbox& mailbox, const gpu::SyncToken& syncToken)

+PassRefPtr<AcceleratedStaticBitmapImage> AcceleratedStaticBitmapImage::createFromWebGLContextImage(sk_sp<SkImage> image, const gpu::Mailbox& mailbox, const gpu::SyncToken& syncToken, GLuint textureId)

danakj 2016/09/09 20:51:42 "textureId" for what? Can you make this name expla

{

- return adoptRef(new AcceleratedStaticBitmapImage(std::move(image), mailbox, syncToken));

+ return adoptRef(new AcceleratedStaticBitmapImage(std::move(image), mailbox, syncToken, textureId));

}

AcceleratedStaticBitmapImage::AcceleratedStaticBitmapImage(sk_sp<SkImage> image)

@@ -40,12 +40,13 @@ AcceleratedStaticBitmapImage::AcceleratedStaticBitmapImage(sk_sp<SkImage> image)

m_threadChecker.DetachFromThread();

}

-AcceleratedStaticBitmapImage::AcceleratedStaticBitmapImage(sk_sp<SkImage> image, const gpu::Mailbox& mailbox, const gpu::SyncToken& syncToken)

+AcceleratedStaticBitmapImage::AcceleratedStaticBitmapImage(sk_sp<SkImage> image, const gpu::Mailbox& mailbox, const gpu::SyncToken& syncToken, GLuint textureId)

: StaticBitmapImage(std::move(image))

, m_sharedContextId(SharedGpuContext::kNoSharedContext)

, m_hasMailbox(true)

, m_mailbox(mailbox)

, m_syncToken(syncToken)

+ , m_textureId(textureId)

{

m_threadChecker.DetachFromThread();