Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2328433005: Fix kLargestDrawQuadSize (Closed)

Created:
4 years, 3 months ago by hubbe
Modified:
4 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix kLargestDrawQuadSize This should work, but triggered a bug in the past. Trying again, if nothing else I'll find out what problem was triggered. BUG=644443 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/e099ceca4f5145bf650a2293807c585cc717121f Cr-Commit-Position: refs/heads/master@{#417646}

Patch Set 1 #

Patch Set 2 : try again #

Patch Set 3 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M cc/quads/draw_quad_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/quads/largest_draw_quad.cc View 1 2 2 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
hubbe
4 years, 3 months ago (2016-09-09 18:30:09 UTC) #7
danakj
Thanks LGTM
4 years, 3 months ago (2016-09-09 18:31:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328433005/1
4 years, 3 months ago (2016-09-09 18:31:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 18:36:51 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e099ceca4f5145bf650a2293807c585cc717121f Cr-Commit-Position: refs/heads/master@{#417646}
4 years, 3 months ago (2016-09-09 18:39:26 UTC) #13
dmurph
4 years, 3 months ago (2016-09-09 21:00:42 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2326153002/ by dmurph@chromium.org.

The reason for reverting is: Reverting, I think this caused buffer size issues
https://bugs.chromium.org/p/chromium/issues/detail?id=645634
BUG=645634.

Powered by Google App Engine
This is Rietveld 408576698