Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: cc/quads/largest_draw_quad.cc

Issue 2328433005: Fix kLargestDrawQuadSize (Closed)
Patch Set: try again Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/quads/draw_quad_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/quads/largest_draw_quad.h" 5 #include "cc/quads/largest_draw_quad.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
11 #include "cc/quads/debug_border_draw_quad.h" 11 #include "cc/quads/debug_border_draw_quad.h"
12 #include "cc/quads/picture_draw_quad.h" 12 #include "cc/quads/picture_draw_quad.h"
13 #include "cc/quads/render_pass_draw_quad.h" 13 #include "cc/quads/render_pass_draw_quad.h"
14 #include "cc/quads/solid_color_draw_quad.h" 14 #include "cc/quads/solid_color_draw_quad.h"
15 #include "cc/quads/stream_video_draw_quad.h" 15 #include "cc/quads/stream_video_draw_quad.h"
16 #include "cc/quads/surface_draw_quad.h" 16 #include "cc/quads/surface_draw_quad.h"
17 #include "cc/quads/texture_draw_quad.h" 17 #include "cc/quads/texture_draw_quad.h"
18 #include "cc/quads/tile_draw_quad.h" 18 #include "cc/quads/tile_draw_quad.h"
19 #include "cc/quads/yuv_video_draw_quad.h" 19 #include "cc/quads/yuv_video_draw_quad.h"
20 20
21 namespace { 21 namespace {
22 const size_t kLargestDrawQuadSize = 22 const size_t kLargestDrawQuadSize1 = sizeof(cc::StreamVideoDrawQuad);
23 sizeof(cc::YUVVideoDrawQuad) + sizeof(gfx::ColorSpace); 23 const size_t kLargestDrawQuadSize2 = sizeof(cc::RenderPassDrawQuad) >
24 kLargestDrawQuadSize1
25 ? sizeof(cc::RenderPassDrawQuad)
26 : kLargestDrawQuadSize1;
27 const size_t kLargestDrawQuadSize = sizeof(cc::YUVVideoDrawQuad) >
28 kLargestDrawQuadSize2
29 ? sizeof(cc::YUVVideoDrawQuad)
30 : kLargestDrawQuadSize2;
31
24 } // namespace 32 } // namespace
25 33
26 namespace cc { 34 namespace cc {
27 35
28 size_t LargestDrawQuadSize() { 36 size_t LargestDrawQuadSize() {
29 // Currently the largest quad is either a RenderPassDrawQuad or a 37 // Currently the largest quad is either a RenderPassDrawQuad,
30 // StreamVideoDrawQuad depends on hardware structure. 38 // StreamVideoDrawQuad or YUVVideoDrawQuad depending on hardware structure.
31 39
32 // Use compile assert to make sure largest is actually larger than all other 40 // Use compile assert to make sure largest is actually larger than all
33 // type of draw quads. 41 // type of draw quads.
34 static_assert(sizeof(DebugBorderDrawQuad) <= kLargestDrawQuadSize, 42 static_assert(sizeof(DebugBorderDrawQuad) <= kLargestDrawQuadSize,
35 "Largest Draw Quad size needs update. DebugBorderDrawQuad is " 43 "Largest Draw Quad size needs update. DebugBorderDrawQuad is "
36 "currently largest."); 44 "currently largest.");
37 static_assert(sizeof(PictureDrawQuad) <= kLargestDrawQuadSize, 45 static_assert(sizeof(PictureDrawQuad) <= kLargestDrawQuadSize,
38 "Largest Draw Quad size needs update. PictureDrawQuad is " 46 "Largest Draw Quad size needs update. PictureDrawQuad is "
39 "currently largest."); 47 "currently largest.");
40 static_assert(sizeof(TextureDrawQuad) <= kLargestDrawQuadSize, 48 static_assert(sizeof(TextureDrawQuad) <= kLargestDrawQuadSize,
41 "Largest Draw Quad size needs update. TextureDrawQuad is " 49 "Largest Draw Quad size needs update. TextureDrawQuad is "
42 "currently largest."); 50 "currently largest.");
43 static_assert(sizeof(SolidColorDrawQuad) <= kLargestDrawQuadSize, 51 static_assert(sizeof(SolidColorDrawQuad) <= kLargestDrawQuadSize,
44 "Largest Draw Quad size needs update. SolidColorDrawQuad is " 52 "Largest Draw Quad size needs update. SolidColorDrawQuad is "
45 "currently largest."); 53 "currently largest.");
46 static_assert(sizeof(SurfaceDrawQuad) <= kLargestDrawQuadSize, 54 static_assert(sizeof(SurfaceDrawQuad) <= kLargestDrawQuadSize,
47 "Largest Draw Quad size needs update. SurfaceDrawQuad is " 55 "Largest Draw Quad size needs update. SurfaceDrawQuad is "
48 "currently largest."); 56 "currently largest.");
49 static_assert(sizeof(TileDrawQuad) <= kLargestDrawQuadSize, 57 static_assert(sizeof(TileDrawQuad) <= kLargestDrawQuadSize,
50 "Largest Draw Quad size needs update. TileDrawQuad is " 58 "Largest Draw Quad size needs update. TileDrawQuad is "
51 "currently largest."); 59 "currently largest.");
52 static_assert(sizeof(YUVVideoDrawQuad) <= kLargestDrawQuadSize, 60 static_assert(sizeof(YUVVideoDrawQuad) <= kLargestDrawQuadSize,
53 "Largest Draw Quad size needs update. YUVVideoDrawQuad is " 61 "Largest Draw Quad size needs update. YUVVideoDrawQuad is "
54 "currently largest."); 62 "currently largest.");
63 static_assert(sizeof(RenderPassDrawQuad) <= kLargestDrawQuadSize,
64 "Largest Draw Quad size needs update. RenderPassDrawQuad is "
65 "currently largest.");
66 static_assert(sizeof(StreamVideoDrawQuad) <= kLargestDrawQuadSize,
67 "Largest Draw Quad size needs update. StreamVideoDrawQuad is "
68 "currently largest.");
55 69
56 return kLargestDrawQuadSize; 70 return kLargestDrawQuadSize;
57 } 71 }
58 72
59 } // namespace cc 73 } // namespace cc
OLDNEW
« no previous file with comments | « cc/quads/draw_quad_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698