Cleanups of PaintController

Cleanups of PaintController

- Remove an unused method declaration;
- Don't print debug string of the current display item client in
  NDEBUG mode:
    // In NDEBUG mode we call DisplayItemClient::debugName()
    // in displayItemListAsDebugString() which can only be called
    // when we are sure the client is still alive. It's not
    // suitable for m_currentPaintArtifact.getDisplayItemList().
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/a19b0818793a6e872af045af0e317c7fbf88924a
Cr-Commit-Position: refs/heads/master@{#418088}

[Xianzhu, 2016-09-12 17:51:03]

Description was changed from

==========
Cleanups of PaintController

- Remove an unused method declaration;
- Don't print debug string of the current display item client in
  NDEBUG mode:
    // In NDEBUG mode we call DisplayItemClient::debugName()
    // in displayItemListAsDebugString() which can only be called
    // when we are sure the client is still alive. It's not
    // suitable for m_currentPaintArtifact.getDisplayItemList().
==========

to

==========
Cleanups of PaintController

- Remove an unused method declaration;
- Don't print debug string of the current display item client in
  NDEBUG mode:
    // In NDEBUG mode we call DisplayItemClient::debugName()
    // in displayItemListAsDebugString() which can only be called
    // when we are sure the client is still alive. It's not
    // suitable for m_currentPaintArtifact.getDisplayItemList().
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-12 17:52:16]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2016-09-12 17:52:47]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2016-09-12 17:53:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 18:49:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 18:49:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pdr., 2016-09-12 19:45:07]

https://codereview.chromium.org/2328413002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(right):

https://codereview.chromium.org/2328413002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:742:
#ifndef NDEBUG
I'd prefer if this function didn't work completely differently depending on
ndebug. Is there a way to check for liveness in displayItemListAsDebugString in
ndebug mode and still print the rest of the information? If not, could we just
delete the m_currentPaintArtifact part?

[Xianzhu, 2016-09-12 20:54:49]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-09-12 20:54:49]

+chrishtr@ who enabled showDebugData() in release mode.

https://codereview.chromium.org/2328413002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(right):

https://codereview.chromium.org/2328413002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:742:
#ifndef NDEBUG
On 2016/09/12 19:45:07, pdr. wrote:
> I'd prefer if this function didn't work completely differently depending on
> ndebug. Is there a way to check for liveness in displayItemListAsDebugString
in
> ndebug mode and still print the rest of the information? If not, could we just
> delete the m_currentPaintArtifact part?

We can't enable liveness checking in release build because it's expensive.
The m_currentPaintArtifact is important for debugging the merge algorithm.

In the new patch set, I changed PaintController::displayItemListAsDebugString()
instead of PaintController::showDebugDataInternal() to minimize the differences
between release and debug builds.

[pdr., 2016-09-12 20:58:20]

On 2016/09/12 at 20:54:49, wangxianzhu wrote:
> +chrishtr@ who enabled showDebugData() in release mode.
> 
>
https://codereview.chromium.org/2328413002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(right):
> 
>
https://codereview.chromium.org/2328413002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:742:
#ifndef NDEBUG
> On 2016/09/12 19:45:07, pdr. wrote:
> > I'd prefer if this function didn't work completely differently depending on
> > ndebug. Is there a way to check for liveness in displayItemListAsDebugString
in
> > ndebug mode and still print the rest of the information? If not, could we
just
> > delete the m_currentPaintArtifact part?
> 
> We can't enable liveness checking in release build because it's expensive.
> The m_currentPaintArtifact is important for debugging the merge algorithm.
> 
> In the new patch set, I changed
PaintController::displayItemListAsDebugString() instead of
PaintController::showDebugDataInternal() to minimize the differences between
release and debug builds.

LGTM

[Xianzhu, 2016-09-12 21:27:38]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-12 21:27:38]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2328413002/#ps40001
(title: "-")

[commit-bot: I haz the power, 2016-09-12 21:28:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 22:55:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-12 22:57:21]

Description was changed from

==========
Cleanups of PaintController

- Remove an unused method declaration;
- Don't print debug string of the current display item client in
  NDEBUG mode:
    // In NDEBUG mode we call DisplayItemClient::debugName()
    // in displayItemListAsDebugString() which can only be called
    // when we are sure the client is still alive. It's not
    // suitable for m_currentPaintArtifact.getDisplayItemList().
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Cleanups of PaintController

- Remove an unused method declaration;
- Don't print debug string of the current display item client in
  NDEBUG mode:
    // In NDEBUG mode we call DisplayItemClient::debugName()
    // in displayItemListAsDebugString() which can only be called
    // when we are sure the client is still alive. It's not
    // suitable for m_currentPaintArtifact.getDisplayItemList().
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/a19b0818793a6e872af045af0e317c7fbf88924a
Cr-Commit-Position: refs/heads/master@{#418088}
==========

[commit-bot: I haz the power, 2016-09-12 22:57:22]

Patchset 3 (id:??) landed as
https://crrev.com/a19b0818793a6e872af045af0e317c7fbf88924a
Cr-Commit-Position: refs/heads/master@{#418088}