Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 2328413002: Cleanups of PaintController (Closed)
Patch Set: - Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PaintController_h 5 #ifndef PaintController_h
6 #define PaintController_h 6 #define PaintController_h
7 7
8 #include "platform/PlatformExport.h" 8 #include "platform/PlatformExport.h"
9 #include "platform/RuntimeEnabledFeatures.h" 9 #include "platform/RuntimeEnabledFeatures.h"
10 #include "platform/geometry/IntRect.h" 10 #include "platform/geometry/IntRect.h"
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 size_t findOutOfOrderCachedItemForward(const DisplayItem::Id&); 207 size_t findOutOfOrderCachedItemForward(const DisplayItem::Id&);
208 void copyCachedSubsequence(size_t&); 208 void copyCachedSubsequence(size_t&);
209 209
210 // Resets the indices (e.g. m_nextItemToMatch) of m_currentPaintArtifact.get DisplayItemList() 210 // Resets the indices (e.g. m_nextItemToMatch) of m_currentPaintArtifact.get DisplayItemList()
211 // to their initial values. This should be called when the DisplayItemList i n m_currentPaintArtifact 211 // to their initial values. This should be called when the DisplayItemList i n m_currentPaintArtifact
212 // is newly created, or is changed causing the previous indices to be invali d. 212 // is newly created, or is changed causing the previous indices to be invali d.
213 void resetCurrentListIndices(); 213 void resetCurrentListIndices();
214 214
215 void generateChunkRasterInvalidationRects(PaintChunk& newChunk); 215 void generateChunkRasterInvalidationRects(PaintChunk& newChunk);
216 void generateChunkRasterInvalidationRectsComparingOldChunk(PaintChunk& newCh unk, const PaintChunk& oldChunk); 216 void generateChunkRasterInvalidationRectsComparingOldChunk(PaintChunk& newCh unk, const PaintChunk& oldChunk);
217 void generateChunkRasterInvalidationRectsForReorderedItems(PaintChunk& newCh unk, const PaintChunk& oldChunk,
218 Vector<size_t>::const_iterator, Vector<size_t>::const_iterator, Vector<s ize_t>::const_iterator, Vector<size_t>::const_iterator);
219 217
220 // The following two methods are for checking under-invalidations 218 // The following two methods are for checking under-invalidations
221 // (when RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled). 219 // (when RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled).
222 void showUnderInvalidationError(const char* reason, const DisplayItem& newIt em, const DisplayItem* oldItem) const; 220 void showUnderInvalidationError(const char* reason, const DisplayItem& newIt em, const DisplayItem* oldItem) const;
223 void checkUnderInvalidation(); 221 void checkUnderInvalidation();
224 bool isCheckingUnderInvalidation() const { return m_underInvalidationCheckin gEnd - m_underInvalidationCheckingBegin > 0; } 222 bool isCheckingUnderInvalidation() const { return m_underInvalidationCheckin gEnd - m_underInvalidationCheckingBegin > 0; }
225 223
226 // The last complete paint artifact. 224 // The last complete paint artifact.
227 // In SPv2, this includes paint chunks as well as display items. 225 // In SPv2, this includes paint chunks as well as display items.
228 PaintArtifact m_currentPaintArtifact; 226 PaintArtifact m_currentPaintArtifact;
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 300
303 #if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS 301 #if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
304 // A stack recording subsequence clients that are currently painting. 302 // A stack recording subsequence clients that are currently painting.
305 Vector<const DisplayItemClient*> m_currentSubsequenceClients; 303 Vector<const DisplayItemClient*> m_currentSubsequenceClients;
306 #endif 304 #endif
307 }; 305 };
308 306
309 } // namespace blink 307 } // namespace blink
310 308
311 #endif // PaintController_h 309 #endif // PaintController_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698